Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1490265

[PATCH RT 2/9] timers: wakeup all timer waiters without holding the base lock

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject [PATCH RT 2/9] timers: wakeup all timer waiters without holding the base lock
Date 2016-09-23 17:40 +0200
Message-ID <skAJX-5CZ-13@gated-at.bofh.it> (permalink)
References <skAAh-5zK-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


3.12.63-rt85-rc2 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

There should be no need to hold the base lock during the wakeup. There
should be no boosting involved, the wakeup list has its own lock so it
should be safe to do this without the lock.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/timer.c b/kernel/timer.c
index 13d87cffb33e..3c3bc6bba12e 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1267,8 +1267,8 @@ static inline void __run_timers(struct tvec_base *base)
 			}
 		}
 	}
-	wakeup_timer_waiters(base);
 	spin_unlock_irq(&base->lock);
+	wakeup_timer_waiters(base);
 }
 
 #ifdef CONFIG_NO_HZ_COMMON
-- 
2.8.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH RT 0/9] Linux 3.12.63-rt85-rc2 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 8/9] fs/dcache: incremental fixup of the retry routine Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 6/9] net: add a lock around icmp_sk() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 4/9] scsi/fcoe: Fix get_cpu()/put_cpu_light() imbalance in  fcoe_recv_frame() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 3/9] sched: lazy_preempt: avoid a warning in the !RT case Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  Re: [PATCH RT 0/9] Linux 3.12.63-rt85-rc2 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 2/9] timers: wakeup all timer waiters without holding the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 5/9] net: add back the missing serialization in ip_send_unicast_reply() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 7/9] fs/dcache: resched/chill only if we make no progress Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 1/9] timers: wakeup all timer waiters Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200

csiph-web