Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490256

[PATCH RT 8/9] fs/dcache: incremental fixup of the retry routine

Show all headers | View raw

3.12.63-rt85-rc2 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

It has been pointed out by tglx that on UP the non-RT task could spin
its entire time slice because the lock owner is preempted. This won't
happen on !RT. So we back to "chill" if we can't cond_resched() did not
work.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 fs/dcache.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index cc739409efbf..b6cebcacfacd 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -39,8 +39,6 @@
 #include <linux/prefetch.h>
 #include <linux/ratelimit.h>
 #include <linux/list_lru.h>
-#include <linux/sched/rt.h>
-#include <linux/sched/deadline.h>
 #include "internal.h"
 #include "mount.h"
 
@@ -656,10 +654,11 @@ kill_it:
 		if (parent == dentry) {
 			/* the task with the highest priority won't schedule */
 			r = cond_resched();
-			if (!r && (rt_task(current) || dl_task(current)))
+			if (!r)
 				cpu_chill();
-		} else
+		} else {
 			dentry = parent;
+		}
 		goto repeat;
 	}
 }
-- 
2.8.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RT 0/9] Linux 3.12.63-rt85-rc2 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 8/9] fs/dcache: incremental fixup of the retry routine Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 6/9] net: add a lock around icmp_sk() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 4/9] scsi/fcoe: Fix get_cpu()/put_cpu_light() imbalance in  fcoe_recv_frame() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  [PATCH RT 3/9] sched: lazy_preempt: avoid a warning in the !RT case Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:30 +0200
  Re: [PATCH RT 0/9] Linux 3.12.63-rt85-rc2 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 2/9] timers: wakeup all timer waiters without holding the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 5/9] net: add back the missing serialization in ip_send_unicast_reply() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 7/9] fs/dcache: resched/chill only if we make no progress Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200
  [PATCH RT 1/9] timers: wakeup all timer waiters Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 17:40 +0200

csiph-web