Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487248

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

From Gustavo Padovan <gustavo@padovan.org>
Newsgroups linux.kernel
Subject Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Date 2016-09-20 13:20 +0200
Message-ID <sjrfI-2eQ-23@gated-at.bofh.it> (permalink)
References <siJHI-8bB-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:

> We get 1 warning when building kernel with W=1:
> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/dma-buf/sw_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding this.

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 14:50 +0200
  Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Gustavo Padovan <gustavo@padovan.org> - 2016-09-20 13:20 +0200
    Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Sumit Semwal <sumit.semwal@linaro.org> - 2016-09-20 15:00 +0200
      Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-22 09:00 +0200

csiph-web