Re: Staging: Media: Lirc - Fix possible ERR_PTR() dereferencing.

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: Staging: Media: Lirc - Fix possible ERR_PTR() dereferencing.
Date	2016-09-20 10:50 +0200
Message-ID	<sjoUy-Bu-25@gated-at.bofh.it> (permalink)
References	<sjnc5-7VS-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 20, 2016 at 12:21:21PM +0530, Shailendra Verma wrote:
> This is of course wrong to call kfree() if memdup_user() fails,
> no memory was allocated and the error in the error-valued pointer
> should be returned.
> 
> Reviewed-by: Ravikant Sharma <ravikant.s2@samsung.com>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>

Calling kfree(NULL) is fine so there is no bug in the original code.
Also this patch creates a new locking bug.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Staging: Media: Lirc - Fix possible ERR_PTR() dereferencing. Shailendra Verma <shailendra.v@samsung.com> - 2016-09-20 09:00 +0200
  Re: Staging: Media: Lirc - Fix possible ERR_PTR() dereferencing. Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-20 10:50 +0200

csiph-web