Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps

From	Sonny Rao <sonnyrao@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps
Date	2016-09-20 02:40 +0200
Message-ID	<sjhgl-4gO-3@gated-at.bofh.it> (permalink)
References	(6 earlier) <sh2v8-6Mr-3@gated-at.bofh.it> <shewh-7tn-5@gated-at.bofh.it> <sj8wq-74K-17@gated-at.bofh.it> <sjcA1-17g-7@gated-at.bofh.it> <sjh6F-4dN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 19, 2016 at 5:27 PM, Robert Foss <robert.foss@collabora.com> wrote:
>
>
> On 2016-09-19 03:32 PM, Michal Hocko wrote:
>>
>> On Mon 19-09-16 11:16:31, Robert Foss wrote:
>>>
>>> On 2016-09-14 05:12 AM, Michal Hocko wrote:
>>>>
>>>> On Tue 13-09-16 13:27:39, Sonny Rao wrote:
>>
>> [...]
>>>>>
>>>>> Given that smaps
>>>>> doesn't provide this in a straightforward way, what do you think is
>>>>> the right way to provide this information?
>>>>
>>>>
>>>> I would be tempted to sneak it into /proc/<pid>/statm because that looks
>>>> like a proper place but getting this information is not for free
>>>> performance wise so I am not really sure something that relies on this
>>>> file would see unexpected stalls. Maybe this could be worked around by
>>>> some caching... I would suggest to check who is actually using this file
>>>> (top/ps etc...)
>>>
>>>
>>> What would this caching look like? Can any information be re-used between
>>> vma walks?
>>
>>
>> yes basically return the same value if called within HZ or something
>> similar. But that assumes that statm latency really matters and it is
>> called often enough.
>
>
> Any single application querying more often than HZ, would presumably do so
> for accuracy reasons.
> However for multiple applications that combined query more often than HZ,
> this would most definitely be halpful in terms of performance.
>
> @Sonny, does chromiumos fall into the first or second category?

It's a single application -- and it definitely doesn't query at HZ --
especially given how long it takes to gather the data :-)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Michal Hocko <mhocko@kernel.org> - 2016-09-12 14:10 +0200
  Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Sonny Rao <sonnyrao@chromium.org> - 2016-09-12 17:50 +0200
    Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Michal Hocko <mhocko@kernel.org> - 2016-09-12 19:20 +0200
      Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Sonny Rao <sonnyrao@chromium.org> - 2016-09-12 19:30 +0200
        Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Michal Hocko <mhocko@kernel.org> - 2016-09-13 09:20 +0200
          Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Sonny Rao <sonnyrao@chromium.org> - 2016-09-13 22:30 +0200
            Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Michal Hocko <mhocko@kernel.org> - 2016-09-14 11:20 +0200
              Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Robert Foss <robert.foss@collabora.com> - 2016-09-19 17:20 +0200
                Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Michal Hocko <mhocko@kernel.org> - 2016-09-19 21:40 +0200
                Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Jann Horn <jann@thejh.net> - 2016-09-19 22:00 +0200
                Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Sonny Rao <sonnyrao@chromium.org> - 2016-09-19 22:20 +0200
                Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Robert Foss <robert.foss@collabora.com> - 2016-09-20 02:30 +0200
                Re: [PATCH v5 0/3] mm, proc: Implement /proc/<pid>/totmaps Sonny Rao <sonnyrao@chromium.org> - 2016-09-20 02:40 +0200

csiph-web