Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486699

Re: [PATCH 1/5] drm/amdgpu: Use kmalloc_array() in amdgpu_debugfs_gca_config_read()

Show all headers | View raw

On Sun, Sep 18, 2016 at 12:50 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 18 Sep 2016 17:00:52 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied.  thanks.

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index df7ab245..2709ebd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2438,7 +2438,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
>         if (size & 0x3 || *pos & 0x3)
>                 return -EINVAL;
>
> -       config = kmalloc(256 * sizeof(*config), GFP_KERNEL);
> +       config = kmalloc_array(256, sizeof(*config), GFP_KERNEL);
>         if (!config)
>                 return -ENOMEM;
>
> --
> 2.10.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] drm/amdgpu: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-18 18:50 +0200
  [PATCH 3/5] drm/amdgpu: Rename a jump label in  amdgpu_debugfs_regs_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-18 19:00 +0200
  [PATCH 4/5] drm/amdgpu: Rename a jump label in amdgpu_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-18 19:00 +0200
    RE: [PATCH 4/5] drm/amdgpu: Rename a jump label in  amdgpu_device_init() "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-09-19 17:10 +0200
  [PATCH 5/5] drm/amdgpu: Adjust checks for null pointers in nine  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-18 19:00 +0200
  [PATCH 1/5] drm/amdgpu: Use kmalloc_array() in  amdgpu_debugfs_gca_config_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-18 19:00 +0200
    Re: [PATCH 1/5] drm/amdgpu: Use kmalloc_array() in amdgpu_debugfs_gca_config_read() Alex Deucher <alexdeucher@gmail.com> - 2016-09-19 19:30 +0200
  [PATCH 2/5] drm/amdgpu: Improve determination of sizes in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-18 19:00 +0200

csiph-web