Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488393

Re: [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries
Date 2016-09-21 23:10 +0200
Message-ID <sjWWd-5EH-1@gated-at.bofh.it> (permalink)
References <sjJFD-5Ct-5@gated-at.bofh.it> <sjJFE-5Ct-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, Sep 21, 2016 at 08:51:06AM +0200, Jan Glauber wrote:
> Do not infinitely retry register readq and writeq operations
> in order to not lock up the CPU in case the TWSI gets stuck.
> 
> Return -EIO in case of a failed data read. For all other
> cases just return so subsequent operations will fail
> and trigger the recovery.
> 
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

I didn't really check, but have you considered using
readq_poll_timeout() from iopoll.h?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] i2c: octeon,thunderx: Recovery fixes and improvements Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
  [PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200
  [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200
  [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 4/5] i2c: octeon,thunderx: Check bus state before  starting a transaction Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:00 +0200
  [PATCH 3/5] i2c: octeon,thunderx: Fix high-level controller status check Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 3/5] i2c: octeon,thunderx: Fix high-level controller  status check Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200
  [PATCH 2/5] i2c: octeon,thunderx: Avoid sending STOP during recovery Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 2/5] i2c: octeon,thunderx: Avoid sending STOP during  recovery Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200

csiph-web