Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487844

[PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function

From Jan Glauber <jglauber@cavium.com>
Newsgroups linux.kernel
Subject [PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function
Date 2016-09-21 09:00 +0200
Message-ID <sjJFD-5Ct-9@gated-at.bofh.it> (permalink)
References <sjJFD-5Ct-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Dmitry Bazhenov <dmitry.bazhenov@auriga.com>

The set SCL recovery function unconditionally pulls the SCL line low.
Only pull SCL line low according to val parameter.

Signed-off-by: Dmitry Bazhenov <dmitry.bazhenov@auriga.com>
Signed-off-by: Jan Glauber <jglauber@cavium.com>
[Changed commit message]
---
 drivers/i2c/busses/i2c-octeon-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
index f45ea5e..f322242 100644
--- a/drivers/i2c/busses/i2c-octeon-core.c
+++ b/drivers/i2c/busses/i2c-octeon-core.c
@@ -767,7 +767,7 @@ static void octeon_i2c_set_scl(struct i2c_adapter *adap, int val)
 {
 	struct octeon_i2c *i2c = i2c_get_adapdata(adap);
 
-	octeon_i2c_write_int(i2c, TWSI_INT_SCL_OVR);
+	octeon_i2c_write_int(i2c, val ? 0 : TWSI_INT_SCL_OVR);
 }
 
 static int octeon_i2c_get_sda(struct i2c_adapter *adap)
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] i2c: octeon,thunderx: Recovery fixes and improvements Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
  [PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200
  [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200
  [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 4/5] i2c: octeon,thunderx: Check bus state before  starting a transaction Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:00 +0200
  [PATCH 3/5] i2c: octeon,thunderx: Fix high-level controller status check Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 3/5] i2c: octeon,thunderx: Fix high-level controller  status check Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200
  [PATCH 2/5] i2c: octeon,thunderx: Avoid sending STOP during recovery Jan Glauber <jglauber@cavium.com> - 2016-09-21 09:00 +0200
    Re: [PATCH 2/5] i2c: octeon,thunderx: Avoid sending STOP during  recovery Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 23:10 +0200

csiph-web