Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488272

[PATCH 06/14] GPU-DRM-OMAP: Improve a size determination in omap_dmm_probe()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 21 Sep 2016 17:21:57 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index f110965..c6a7197 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
@@ -735,7 +735,8 @@ static int omap_dmm_probe(struct platform_device *dev)
 
 	/* alloc engines */
 	omap_dmm->engines = kcalloc(omap_dmm->num_engines,
-				    sizeof(struct refill_engine), GFP_KERNEL);
+				    sizeof(*omap_dmm->engines),
+				    GFP_KERNEL);
 	if (!omap_dmm->engines) {
 		ret = -ENOMEM;
 		goto fail;
-- 
2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] GPU-DRM-OMAP: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:40 +0200
  [PATCH 02/14] GPU-DRM-OMAP: Replace another kmalloc() call by  kmalloc_array() in tiler_map_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:40 +0200
  [PATCH 01/14] GPU-DRM-OMAP: Use kmalloc_array() in tiler_map_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:40 +0200
  [PATCH 05/14] GPU-DRM-OMAP: Improve a size determination in  dmm_txn_append() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 04/14] GPU-DRM-OMAP: Delete an unnecessary variable  initialisation in tiler_map_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 04/14] GPU-DRM-OMAP: Delete an unnecessary variable  initialisation in tiler_map_show() Markus Elfring <Markus.Elfring@web.de> - 2016-09-21 18:50 +0200
  [PATCH 07/14] GPU-DRM-OMAP: Rename a jump label in omap_dmm_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 03/14] GPU-DRM-OMAP: Less function calls in tiler_map_show()  after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 06/14] GPU-DRM-OMAP: Improve a size determination in  omap_dmm_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 08/14] GPU-DRM-OMAP: Rename a jump label in dmm_txn_commit() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 13/14] GPU-DRM-OMAP: Rename a jump label in  omap_gem_new_dmabuf() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 12/14] GPU-DRM-OMAP: Move a variable assignment in  omap_gem_attach_pages() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 11/14] GPU-DRM-OMAP: Replace a kzalloc() call by kcalloc() in  omap_gem_attach_pages() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 09/14] GPU-DRM-OMAP: Delete an unnecessary variable  initialisation in dmm_txn_commit() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 14/14] GPU-DRM-OMAP: Rename a jump label in four functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 10/14] GPU-DRM-OMAP: Use kmalloc_array() in  omap_gem_attach_pages() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  Re: [PATCH 00/14] GPU-DRM-OMAP: Fine-tuning for several function  implementations Daniel Vetter <daniel@ffwll.ch> - 2016-09-22 08:50 +0200
    Re: [PATCH 00/14] GPU-DRM-OMAP: Fine-tuning for several function implementations Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-09-22 09:00 +0200
      Re: GPU-DRM-OMAP: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 11:20 +0200

csiph-web