Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488269

[PATCH 07/14] GPU-DRM-OMAP: Rename a jump label in omap_dmm_probe()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 07/14] GPU-DRM-OMAP: Rename a jump label in omap_dmm_probe()
Date 2016-09-21 18:50 +0200
Message-ID <sjSSC-2Xx-17@gated-at.bofh.it> (permalink)
References <qEuGl-43C-5@gated-at.bofh.it> <sjSIW-2Ud-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 21 Sep 2016 17:30:25 +0200

Adjust jump labels according to the current Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index c6a7197..5f6f21b 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
@@ -624,7 +624,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 
 	omap_dmm = kzalloc(sizeof(*omap_dmm), GFP_KERNEL);
 	if (!omap_dmm)
-		goto fail;
+		goto check_dmm_removal;
 
 	/* initialize lists */
 	INIT_LIST_HEAD(&omap_dmm->alloc_head);
@@ -648,20 +648,20 @@ static int omap_dmm_probe(struct platform_device *dev)
 	mem = platform_get_resource(dev, IORESOURCE_MEM, 0);
 	if (!mem) {
 		dev_err(&dev->dev, "failed to get base address resource\n");
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	omap_dmm->base = ioremap(mem->start, SZ_2K);
 
 	if (!omap_dmm->base) {
 		dev_err(&dev->dev, "failed to get dmm base address\n");
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	omap_dmm->irq = platform_get_irq(dev, 0);
 	if (omap_dmm->irq < 0) {
 		dev_err(&dev->dev, "failed to get IRQ resource\n");
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	omap_dmm->dev = &dev->dev;
@@ -699,7 +699,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 		dev_err(&dev->dev, "couldn't register IRQ %d, error %d\n",
 			omap_dmm->irq, ret);
 		omap_dmm->irq = -1;
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	/* Enable all interrupts for each refill engine except
@@ -714,13 +714,13 @@ static int omap_dmm_probe(struct platform_device *dev)
 	if (!omap_dmm->dummy_page) {
 		dev_err(&dev->dev, "could not allocate dummy page\n");
 		ret = -ENOMEM;
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	/* set dma mask for device */
 	ret = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
 	if (ret)
-		goto fail;
+		goto check_dmm_removal;
 
 	omap_dmm->dummy_pa = page_to_phys(omap_dmm->dummy_page);
 
@@ -730,7 +730,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 					   &omap_dmm->refill_pa, GFP_KERNEL);
 	if (!omap_dmm->refill_va) {
 		dev_err(&dev->dev, "could not allocate refill memory\n");
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	/* alloc engines */
@@ -739,7 +739,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 				    GFP_KERNEL);
 	if (!omap_dmm->engines) {
 		ret = -ENOMEM;
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	for (i = 0; i < omap_dmm->num_engines; i++) {
@@ -758,7 +758,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 				GFP_KERNEL);
 	if (!omap_dmm->tcm) {
 		ret = -ENOMEM;
-		goto fail;
+		goto check_dmm_removal;
 	}
 
 	/* init containers */
@@ -772,7 +772,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 		if (!omap_dmm->tcm[i]) {
 			dev_err(&dev->dev, "failed to allocate container\n");
 			ret = -ENOMEM;
-			goto fail;
+			goto check_dmm_removal;
 		}
 
 		omap_dmm->tcm[i]->lut_id = i;
@@ -812,8 +812,7 @@ static int omap_dmm_probe(struct platform_device *dev)
 	dev_info(omap_dmm->dev, "initialized all PAT entries\n");
 
 	return 0;
-
-fail:
+ check_dmm_removal:
 	if (omap_dmm_remove(dev))
 		dev_err(&dev->dev, "cleanup failed\n");
 	return ret;
-- 
2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] GPU-DRM-OMAP: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:40 +0200
  [PATCH 02/14] GPU-DRM-OMAP: Replace another kmalloc() call by  kmalloc_array() in tiler_map_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:40 +0200
  [PATCH 01/14] GPU-DRM-OMAP: Use kmalloc_array() in tiler_map_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:40 +0200
  [PATCH 05/14] GPU-DRM-OMAP: Improve a size determination in  dmm_txn_append() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 04/14] GPU-DRM-OMAP: Delete an unnecessary variable  initialisation in tiler_map_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 04/14] GPU-DRM-OMAP: Delete an unnecessary variable  initialisation in tiler_map_show() Markus Elfring <Markus.Elfring@web.de> - 2016-09-21 18:50 +0200
  [PATCH 07/14] GPU-DRM-OMAP: Rename a jump label in omap_dmm_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 03/14] GPU-DRM-OMAP: Less function calls in tiler_map_show()  after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 06/14] GPU-DRM-OMAP: Improve a size determination in  omap_dmm_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 18:50 +0200
  [PATCH 08/14] GPU-DRM-OMAP: Rename a jump label in dmm_txn_commit() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 13/14] GPU-DRM-OMAP: Rename a jump label in  omap_gem_new_dmabuf() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 12/14] GPU-DRM-OMAP: Move a variable assignment in  omap_gem_attach_pages() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 11/14] GPU-DRM-OMAP: Replace a kzalloc() call by kcalloc() in  omap_gem_attach_pages() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 09/14] GPU-DRM-OMAP: Delete an unnecessary variable  initialisation in dmm_txn_commit() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 14/14] GPU-DRM-OMAP: Rename a jump label in four functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  [PATCH 10/14] GPU-DRM-OMAP: Use kmalloc_array() in  omap_gem_attach_pages() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-21 19:00 +0200
  Re: [PATCH 00/14] GPU-DRM-OMAP: Fine-tuning for several function  implementations Daniel Vetter <daniel@ffwll.ch> - 2016-09-22 08:50 +0200
    Re: [PATCH 00/14] GPU-DRM-OMAP: Fine-tuning for several function implementations Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-09-22 09:00 +0200
      Re: GPU-DRM-OMAP: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 11:20 +0200

csiph-web