Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev
Date	Wed, 21 Sep 2016 13:40:02 +0200
Message-ID	<sjO2C-8rI-21@gated-at.bofh.it> (permalink)
References	<rsBUK-5fq-11@gated-at.bofh.it> <seMXv-1t1-5@gated-at.bofh.it> <sjO2C-8rI-23@gated-at.bofh.it>
User-Agent	KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:PTLHLt5YAGG/jtuhe+Np1uWvzOtfpZjry9WlJgUTFf2Kvu/DIM9 KKMszZHdFG5intrVgC973ZDSJNdhg5h0A4cFCxr6xtPSmudtI7QXZaQ4Ul17G5XbCZ2MlCW ZYkgviNKZyjLPaH99mEW2dTw6xq8Ajxhkg4bnB6QiclBraDPS8t2Lqstb7Pb8h9jFfFFsix tYXIG0LqzgaI6K5MBdGvw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:NgUGwLVew/o=:Fy4kBfUPDVWBzTeJ5Mh8bj j+FbqxsQ49L3TGqqeIVlxJanbH/39ykxLEnNQOXm91/elY24KDfY6tMiuL2TS2uO+e3YEx34R 1Vpe2NX8M7CqkYK0khy+9BWAcb4wk1llChV6U4iNz9FUr6kolTnwJJEb7EqIaCw0c6hq6JQdK sT2trfC4zKdpwxZ8AA3qkmttTKpnga7YxCSw+QHgMVFEJrIU+vOz2vHBr+u3zouGPd/v9VlFm V4qXFbf0AHzttJPoB6MHGSYDMGdttFDG1ZPZwPpE8uIW6auYfprmXCtsKBc1jDGGV+TCT5jsH LwX2mJAXbITljVrEarPIkRiqYVfRkj/WjxXXaaVlqv2Bn+4n8MwSYyBWWvVA5xbIzOcXNpoVW e7VTAReu7spqjNASIRY44cJ4RCT6xSm5X4+Fp+9uqrGsHv5oBj2lR6fK5LZHqnUuIp14cB2EB 27X6YiQagqFxVQpId7h9kptuRqH4Dto7ZiUJtbZ48YNUb1Ewc/peoQku4grSGu0R8amVejp5v Q/W4gARxTGXRTB6Fs9PI1pNGwUt+zJiFPX3Ema5/rQSiLAjdqvB10UxjOYpoAr0yyvcCFz+WT nVdsAkAq8IMU6p1SMUZcw03TBJ+0XFdSaPsXKvun2Vy4pRWPNlgpQ81wKqmMuC2dv+KKE016j ThKNjrR4HUYdr/ESOAHRzoZbmNkFyu7VCjVu9jb7z8D/9O8H+cATWPIGV+05LA0jPqzXMnRb4 ZqgqnDvU3PzfhW+B
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Felipe Balbi <balbi@kernel.org>, Peter Chen <hzpeterchen@gmail.com>, Leo Li <pku.leo@gmail.com>, Grygorii Strashko <grygorii.strashko@ti.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>, lkml <linux-kernel@vger.kernel.org>, Stuart Yoder <stuart.yoder@nxp.com>, Scott Wood <oss@buserror.net>, David Fisher <david.fisher1@synopsys.com>, "Thang Q. Nguyen" <tqnguyen@apm.com>, Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Suresh Gupta <suresh.gupta@nxp.com>
X-Original-Date	Wed, 21 Sep 2016 13:31:38 +0200
X-Original-Message-ID	<3596831.dckG5peiyF@wuerfel>
X-Original-References	<Pine.LNX.4.44L0.1604271357190.1912-100000@iolanthe.rowland.org> <3189648.KnWLgq0lTY@wuerfel> <DB5PR0401MB19259C5DBD40BEEC70F0B7CEF5F60@DB5PR0401MB1925.eurprd04.prod.outlook.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1488059

Show key headers only | View raw

On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote:
> 
> Hello Arnd,
> 
> We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3 
> controller without any glue layer. On first go, this did not work. But after
> minimal reworks mention snippet below, we are able to verify that the USB
> was working OK.
> 
>  drivers/usb/host/xhci-mem.c | 12 ++++++------
>  drivers/usb/host/xhci.c     | 20 ++++++++++----------
> 
> -       struct device *dev = xhci_to_hcd(xhci)->self.controller;
> +       struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
> 
> We believe the patch needs little modification to work or there might be chances
> we may have missed something. Any idea?

I had not tried the patch, it was just sent for clarification what I
meant, so I'm glad you got it working with just minimal changes.

Unfortunately, I can't tell from your lines above what exactly you
changed, can you send that again as a proper patch?

I think I also had some minimal changes that I did myself in order
to fix a build regression I introduced.

	Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-21 13:40 +0200
  Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-21 14:50 +0200
    RE: [PATCH] usb: dwc3: host: inherit dma configuration from parent  dev Sriram Dash <sriram.dash@nxp.com> - 2016-09-22 10:40 +0200
  RE: [PATCH] usb: dwc3: host: inherit dma configuration from parent  dev Sriram Dash <sriram.dash@nxp.com> - 2016-09-21 17:20 +0200
    Re: [PATCH] usb: xhci: Fix the patch inherit dma configuration from kbuild test robot <lkp@intel.com> - 2016-09-21 19:20 +0200

csiph-web