Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev
Date	2016-09-21 13:40 +0200
Message-ID	<sjO2C-8rI-21@gated-at.bofh.it> (permalink)
References	<rsBUK-5fq-11@gated-at.bofh.it> <seMXv-1t1-5@gated-at.bofh.it> <sjO2C-8rI-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote:
> 
> Hello Arnd,
> 
> We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3 
> controller without any glue layer. On first go, this did not work. But after
> minimal reworks mention snippet below, we are able to verify that the USB
> was working OK.
> 
>  drivers/usb/host/xhci-mem.c | 12 ++++++------
>  drivers/usb/host/xhci.c     | 20 ++++++++++----------
> 
> -       struct device *dev = xhci_to_hcd(xhci)->self.controller;
> +       struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
> 
> We believe the patch needs little modification to work or there might be chances
> we may have missed something. Any idea?

I had not tried the patch, it was just sent for clarification what I
meant, so I'm glad you got it working with just minimal changes.

Unfortunately, I can't tell from your lines above what exactly you
changed, can you send that again as a proper patch?

I think I also had some minimal changes that I did myself in order
to fix a build regression I introduced.

	Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-21 13:40 +0200
  Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-21 14:50 +0200
    RE: [PATCH] usb: dwc3: host: inherit dma configuration from parent  dev Sriram Dash <sriram.dash@nxp.com> - 2016-09-22 10:40 +0200
  RE: [PATCH] usb: dwc3: host: inherit dma configuration from parent  dev Sriram Dash <sriram.dash@nxp.com> - 2016-09-21 17:20 +0200
    Re: [PATCH] usb: xhci: Fix the patch inherit dma configuration from kbuild test robot <lkp@intel.com> - 2016-09-21 19:20 +0200

csiph-web