Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486649

Re: Re: linux-next: build failure after merge of the pm tree

Show all headers | View raw

On Mon, Sep 19, 2016 at 07:37:24AM +0000, MyungJoo Ham wrote:
> > On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> > > Hi Rafael,
> > > 
> > > After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> > > failed like this:
> > > 
> > > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> > > drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
> > >   clk_set_min_rate(tegra->emc_clock, rate);
> > >   ^
> > > 
> > > Caused by commit
> > > 
> > >   797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
> 
> @Rafael: Thank you!
> 
> 
> @Kozlowski:
> 
> It looks like COMMON_CLK is required to be "selected" for TEGRA.
> 
> Although COMMON_CLK is supposed to be widely used by most ARM platforms
> especially if "Multiple platfrom selection" for ARMv7 is used,
> COMPILE_TEST won't recognize it.
> 
> Adding COMMON_CLK for TEGRA will solve this instance of issue; however,
> for COMPILE_TEST to be reasonably robust, each "COMPILE_TEST"ed item
> should "select" every required item. How do you want to proceed with
> COMPILE_TEST on SoC-specific device drivers?

I think drivers should depend on COMMON_CLK in such case. This tegra
driver probably does not require strict ARCH_TEGRA_124_SOC dependency
because it does not use any SoC-specific data/functions etc. However it
uses common clock framework so explicit dependency looks proper to me.

In fact this is already seen in kernel like SND_SOC_TEGRA, SND_MXS_SOC,
PWM_IMG(with compile test), SND_SOC_RCAR (even without compile test).

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the pm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-14 06:30 +0200
  Re: linux-next: build failure after merge of the pm tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-09-14 23:40 +0200
  RE: Re: linux-next: build failure after merge of the pm tree MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-09-19 09:40 +0200
    Re: Re: linux-next: build failure after merge of the pm tree Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-19 18:20 +0200

csiph-web