Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483702

Re: linux-next: build failure after merge of the pm tree

Show all headers | View raw

On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
>   clk_set_min_rate(tegra->emc_clock, rate);
>   ^
> 
> Caused by commit
> 
>   797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
> 
> clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.
> 
> I added the following for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 14 Sep 2016 14:22:25 +1000
> Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
>  COMPILE_TEST for build coverage")
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/devfreq/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index cadd56e50b2c..93b6ada06676 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  
>  config ARM_TEGRA_DEVFREQ
>  	tristate "Tegra DEVFREQ Driver"
> -	depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
> +	depends on ARCH_TEGRA_124_SOC
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select PM_OPP
>  	help

I've just gone ahead and applied it.

Thanks Stephen!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the pm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-14 06:30 +0200
  Re: linux-next: build failure after merge of the pm tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-09-14 23:40 +0200
  RE: Re: linux-next: build failure after merge of the pm tree MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-09-19 09:40 +0200
    Re: Re: linux-next: build failure after merge of the pm tree Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-19 18:20 +0200

csiph-web