Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1486509
| From | John Crispin <john@phrozen.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/4] net-next: dsa: qca8k: remove empty set_addr() stub |
| Date | 2016-09-19 15:30 +0200 |
| Message-ID | <sj6NZ-5YW-83@gated-at.bofh.it> (permalink) |
| References | <sj6NX-5YW-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The set_addr() callback is now optional. Remove the empty stub that qca8k
has.
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/net/dsa/qca8k.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 7f3f178..4788a89 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -586,13 +586,6 @@ qca8k_setup(struct dsa_switch *ds)
}
static int
-qca8k_set_addr(struct dsa_switch *ds, u8 *addr)
-{
- /* The subsystem always calls this function so add an empty stub */
- return 0;
-}
-
-static int
qca8k_phy_read(struct dsa_switch *ds, int phy, int regnum)
{
struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
@@ -921,7 +914,6 @@ qca8k_get_tag_protocol(struct dsa_switch *ds)
static struct dsa_switch_ops qca8k_switch_ops = {
.get_tag_protocol = qca8k_get_tag_protocol,
.setup = qca8k_setup,
- .set_addr = qca8k_set_addr,
.get_strings = qca8k_get_strings,
.phy_read = qca8k_phy_read,
.phy_write = qca8k_phy_write,
--
1.7.10.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] net-next: dsa: set_addr should be optional John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 3/4] net-next: dsa: b53: remove empty set_addr() stub John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 2/4] net-next: dsa: make the set_addr() operation optional John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 4/4] net-next: dsa: qca8k: remove empty set_addr() stub John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr() John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
Re: [PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr() Andrew Lunn <andrew@lunn.ch> - 2016-09-19 15:50 +0200
Re: [PATCH 0/4] net-next: dsa: set_addr should be optional Andrew Lunn <andrew@lunn.ch> - 2016-09-19 15:50 +0200
Re: [PATCH 0/4] net-next: dsa: set_addr should be optional Florian Fainelli <f.fainelli@gmail.com> - 2016-09-19 21:50 +0200
Re: [PATCH 0/4] net-next: dsa: set_addr should be optional David Miller <davem@davemloft.net> - 2016-09-20 10:50 +0200
csiph-web