Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1486510
| From | John Crispin <john@phrozen.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr() |
| Date | 2016-09-19 15:30 +0200 |
| Message-ID | <sj6NZ-5YW-67@gated-at.bofh.it> (permalink) |
| References | <sj6NX-5YW-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
commit 83c0afaec7b730b ("net: dsa: Add new binding implementation")
has a duplicate invocation of the set_addr() operation callback. Remove one
of them.
Signed-off-by: John Crispin <john@phrozen.org>
---
net/dsa/dsa2.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index 8278385..cffc19e 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -308,10 +308,6 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
if (err < 0)
return err;
- err = ds->ops->set_addr(ds, dst->master_netdev->dev_addr);
- if (err < 0)
- return err;
-
if (!ds->slave_mii_bus && ds->ops->phy_read) {
ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
if (!ds->slave_mii_bus)
--
1.7.10.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] net-next: dsa: set_addr should be optional John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 3/4] net-next: dsa: b53: remove empty set_addr() stub John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 2/4] net-next: dsa: make the set_addr() operation optional John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 4/4] net-next: dsa: qca8k: remove empty set_addr() stub John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
[PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr() John Crispin <john@phrozen.org> - 2016-09-19 15:30 +0200
Re: [PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr() Andrew Lunn <andrew@lunn.ch> - 2016-09-19 15:50 +0200
Re: [PATCH 0/4] net-next: dsa: set_addr should be optional Andrew Lunn <andrew@lunn.ch> - 2016-09-19 15:50 +0200
Re: [PATCH 0/4] net-next: dsa: set_addr should be optional Florian Fainelli <f.fainelli@gmail.com> - 2016-09-19 21:50 +0200
Re: [PATCH 0/4] net-next: dsa: set_addr should be optional David Miller <davem@davemloft.net> - 2016-09-20 10:50 +0200
csiph-web