Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'
Date	Sun, 18 Sep 2016 02:10:01 +0200
Message-ID	<sixQd-RQ-3@gated-at.bofh.it> (permalink)
References	<sh93z-2S7-3@gated-at.bofh.it> <shF3r-7Ca-19@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Walleij <linus.walleij@linaro.org>
X-Original-Date	Sun, 18 Sep 2016 08:08:45 +0800
X-Original-Message-ID	<20160918000845.GA15478@tiger>
X-Original-References	<9befb559-499a-dd70-cd44-60d5fce2e5d6@roeck-us.net> <99993063-6692-0870-12fa-64cf13d507f6@mentor.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1485650

Show key headers only | View raw

Hi Guenter,

On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vladimir Zapolskiy wrote:
> The proper fix in this particular case should be like this one:
> 

Does Vladimir's patch below fix your problem?

Shawn

> diff --git a/arch/arm/mach-imx/mach-kzm_arm11_01.c b/arch/arm/mach-imx/mach-kzm_arm11_01.c
> index 31df4361996f..8288acfe7221 100644
> --- a/arch/arm/mach-imx/mach-kzm_arm11_01.c
> +++ b/arch/arm/mach-imx/mach-kzm_arm11_01.c
> @@ -245,13 +245,17 @@ static void __init kzm_board_init(void)
>  	mxc_iomux_setup_multiple_pins(kzm_pins,
>  				      ARRAY_SIZE(kzm_pins), "kzm");
> -	kzm_init_ext_uart();
> -	kzm_init_smsc9118();
>  	kzm_init_imx_uart();
>  	pr_info("Clock input source is 26MHz\n");
>  }
> +static void __init kzm_late_init(void)
> +{
> +	kzm_init_ext_uart();
> +	kzm_init_smsc9118();
> +}
> +
>  /*
>   * This structure defines static mappings for the kzm-arm11-01 board.
>   */
> @@ -291,5 +295,6 @@ MACHINE_START(KZM_ARM11_01, "Kyoto Microcomputer Co., Ltd. KZM-ARM11-01")
>  	.init_irq = mx31_init_irq,
>  	.init_time	= kzm_timer_init,
>  	.init_machine = kzm_board_init,
> +	.init_late	= kzm_late_init,
>  	.restart	= mxc_restart,
>  MACHINE_END
> --

Thread

Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-14 05:30 +0200
  Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-14 09:30 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-14 16:40 +0200
      Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-15 14:20 +0200
        Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:20 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:50 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-15 16:00 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:20 +0200
  Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:40 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-15 16:30 +0200
      Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-15 16:40 +0200
        Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-15 16:50 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-16 04:30 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Shawn Guo <shawnguo@kernel.org> - 2016-09-18 02:10 +0200
      Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-18 03:10 +0200
        Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-18 13:30 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Shawn Guo <shawnguo@kernel.org> - 2016-09-20 15:00 +0200
            Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-20 16:00 +0200
              Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Shawn Guo <shawnguo@kernel.org> - 2016-09-20 16:20 +0200
            Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-20 23:40 +0200

csiph-web