Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484186

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

From Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Newsgroups linux.kernel
Subject Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'
Date 2016-09-15 15:50 +0200
Message-ID <shFd8-7FN-23@gated-at.bofh.it> (permalink)
References <sh93z-2S7-3@gated-at.bofh.it> <shcNP-6gS-7@gated-at.bofh.it> <shjvY-215-13@gated-at.bofh.it> <shDO2-6VP-3@gated-at.bofh.it> <shEK6-7vq-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Linus,

On 09/15/2016 04:18 PM, Vladimir Zapolskiy wrote:
> Hi Linus,
>
> On 09/15/2016 03:19 PM, Linus Walleij wrote:
>> On Wed, Sep 14, 2016 at 4:33 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>>> On 09/14/2016 12:19 AM, Linus Walleij wrote:
>>>>
>>>> On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>>
>>>>> So, in other words, lots of bugs here. Nevertheless, I would suggest to
>>>>> keep
>>>>> using postcore_initcall(), at least until it is sure that all gpio
>>>>> clients handle
>>>>> -EPROBE_DEFER
>>>>> correctly.
>>>>
>>>>
>>>> So can I just revert this patch in isolation? None of the other patches
>>>> depend on it?
>>>>
>>> Good question, if this was part of a series.
>>
>> No response from author, so betting on it and reverting this in isolation
>> with your Reported-by.
>>
>
> please revert the revert :)
>

ok, the problem is recognized, but as I said it is not sufficient to revert
only that change, if it is selected to go by path of reverts commit
("gpio: mxc: add generic gpio request/free callbacks to pinctrl") from
your for-next branch should be reverted as well, the latter commit depends
on the reverted commit.

I have one i.MX31 powered board on hand, I'll start preparing a proper
fix for the issue.

--
With best wishes,
Vladimir

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-14 05:30 +0200
  Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-14 09:30 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-14 16:40 +0200
      Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-15 14:20 +0200
        Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:20 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:50 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-15 16:00 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:20 +0200
  Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-15 15:40 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-15 16:30 +0200
      Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-15 16:40 +0200
        Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-15 16:50 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-16 04:30 +0200
    Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Shawn Guo <shawnguo@kernel.org> - 2016-09-18 02:10 +0200
      Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Guenter Roeck <linux@roeck-us.net> - 2016-09-18 03:10 +0200
        Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-18 13:30 +0200
          Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Shawn Guo <shawnguo@kernel.org> - 2016-09-20 15:00 +0200
            Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-20 16:00 +0200
              Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Shawn Guo <shawnguo@kernel.org> - 2016-09-20 16:20 +0200
            Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift  gpio_mxc_init() to subsys_initcall level' Linus Walleij <linus.walleij@linaro.org> - 2016-09-20 23:40 +0200

csiph-web