Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485600

[PATCH 2/4] carl9170: fix debugfs crashes

Show all headers | View raw

Ben Greear reported:
> I see lots of instability as soon as I load up the carl9710 NIC.
> My application is going to be poking at it's debugfs files...
>
> BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2a0
> [carl9170] at addr ffff8801bc1208b0
> Read of size 8 by task btserver/5888
> =======================================================================
> BUG kmalloc-256 (Tainted: G        W      ): kasan: bad access detected
> -----------------------------------------------------------------------
>
> INFO: Allocated in seq_open+0x50/0x100 age=2690 cpu=2 pid=772
>...

This breakage was caused by the introduction of intermediate
fops in debugfs by commit 9fd4dcece43a
("debugfs: prevent access to possibly dead file_operations at file open")

Thankfully, the original/real fops are still available in d_fsdata.

Reported-by: Ben Greear <greearb@candelatech.com>
Reviewed-by: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 drivers/net/wireless/ath/carl9170/debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/carl9170/debug.c b/drivers/net/wireless/ath/carl9170/debug.c
index 01a0919..ad7ffd5 100644
--- a/drivers/net/wireless/ath/carl9170/debug.c
+++ b/drivers/net/wireless/ath/carl9170/debug.c
@@ -75,7 +75,7 @@ static ssize_t carl9170_debugfs_read(struct file *file, char __user *userbuf,
 
 	if (!ar)
 		return -ENODEV;
-	dfops = container_of(file->f_path.dentry->d_fsdata,
+	dfops = container_of(debugfs_real_fops(file),
 			     struct carl9170_debugfs_fops, fops);
 
 	if (!dfops->read)
@@ -128,7 +128,7 @@ static ssize_t carl9170_debugfs_write(struct file *file,
 
 	if (!ar)
 		return -ENODEV;
-	dfops = container_of(file->f_path.dentry->d_fsdata,
+	dfops = container_of(debugfs_real_fops(file),
 			     struct carl9170_debugfs_fops, fops);
 	if (!dfops->write)
 		return -ENOSYS;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] carl9170: fix debugfs crashes Christian Lamparter <chunkeey@googlemail.com> - 2016-09-17 21:50 +0200
  Re: [PATCH 2/4] carl9170: fix debugfs crashes Greg KH <gregkh@linuxfoundation.org> - 2016-09-17 23:50 +0200
    Re: [PATCH 2/4] carl9170: fix debugfs crashes Kalle Valo <kvalo@codeaurora.org> - 2016-09-18 10:00 +0200
      Re: [PATCH 2/4] carl9170: fix debugfs crashes Greg KH <gregkh@linuxfoundation.org> - 2016-09-18 12:20 +0200
        Re: [PATCH 2/4] carl9170: fix debugfs crashes Christian Lamparter <chunkeey@googlemail.com> - 2016-09-18 14:50 +0200
          Re: [PATCH 2/4] carl9170: fix debugfs crashes Greg KH <gregkh@linuxfoundation.org> - 2016-09-18 18:50 +0200
            Re: [PATCH 2/4] carl9170: fix debugfs crashes Christian Lamparter <chunkeey@googlemail.com> - 2016-09-19 22:20 +0200
              Re: [PATCH 2/4] carl9170: fix debugfs crashes Greg KH <gregkh@linuxfoundation.org> - 2016-09-20 09:00 +0200
        Re: [PATCH 2/4] carl9170: fix debugfs crashes Kalle Valo <kvalo@codeaurora.org> - 2016-09-18 19:00 +0200
  Re: [PATCH 2/4] carl9170: fix debugfs crashes Greg KH <gregkh@linuxfoundation.org> - 2016-09-21 12:20 +0200
    Re: [PATCH 2/4] carl9170: fix debugfs crashes Christian Lamparter <chunkeey@googlemail.com> - 2016-09-21 18:30 +0200
      [PATCH v2] carl9170: fix debugfs crashes Christian Lamparter <chunkeey@googlemail.com> - 2016-09-21 19:00 +0200

csiph-web