Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485599

Re: [PATCH] sbitmap: don't update the allocation hint on clear after resize

Show all headers | View raw

On Sat, Sep 17, 2016 at 01:39:59PM -0600, Jens Axboe wrote:
> On 09/17/2016 01:20 PM, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> > 
> > If we have a bunch of high-numbered bits allocated and then we resize
> > the struct sbitmap_queue, when those bits get cleared, we'll update the
> > hint and then have to re-randomize it repeatedly. Avoid that by checking
> > that the cleared bit is still a valid hint. No measurable performance
> > difference in the common case.
> > 
> > Signed-off-by: Omar Sandoval <osandov@fb.com>
> > ---
> > Jens,
> > 
> > Small tweak to patch 6 that occurred to me after I sent the series out.
> > Feel free to fold it in to patch 6 or apply it separately as you see
> > fit.
> 
> No worries. I can't fold since the series was already applied, so I just
> added the extra patch.
> 

Okay with me, thanks!

-- 
Omar

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sbitmap: don't update the allocation hint on clear after resize Omar Sandoval <osandov@osandov.com> - 2016-09-17 21:30 +0200
  Re: [PATCH] sbitmap: don't update the allocation hint on clear after  resize Omar Sandoval <osandov@osandov.com> - 2016-09-17 21:50 +0200

csiph-web