Re: [PATCH] mlxsw: spectrum: mark symbols static where possible

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.in-chemnitz.de!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Ido Schimmel <idosch@idosch.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mlxsw: spectrum: mark symbols static where possible
Date	Sun, 18 Sep 2016 11:20:01 +0200
Message-ID	<siGqt-6js-3@gated-at.bofh.it> (permalink)
References	<siFXr-5UO-5@gated-at.bofh.it>
X-Original-To	Baoyou Xie <baoyou.xie@linaro.org>
Dkim-Signature	v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=oN2Uyjn5xow/pszhNWEbJAEPX30=; b=KJn1Z wHjrlaqLqpF1hKjEwRvczbUDvp2wWsSijxQ6qq42XvrqwC/iUiqrcDWjq1Y8BrWB F8kfemyTPdH9jLFh1+6F6swBzM55GamE3DVYQ+w9bfbKBQ3/lW2p3BQ0WCXBCwVY yZrHsMIOx+KojdX9V88oThqcwUGgCZRfNWtacM=
X-Sasl-Enc	dmMdmYiDlIr6LrsB87rcUhty9ec6St3oKJT9nYaEVLtr 1474189809
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.0 (2016-08-17)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn
X-Original-Date	Sun, 18 Sep 2016 12:10:08 +0300
X-Original-Message-ID	<20160918091008.GA22506@splinter>
X-Original-References	<1474187987-12958-1-git-send-email-baoyou.xie@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1485741

Show key headers only | View raw

Hi,

On Sun, Sep 18, 2016 at 04:39:47PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:251:29: warning: no previous prototype for 'mlxsw_sp_span_entry_find' [-Wmissing-prototypes]
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:265:29: warning: no previous prototype for 'mlxsw_sp_span_entry_get' [-Wmissing-prototypes]
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:1749:6: warning: no previous prototype for 'mlxsw_sp_fib_entry_put' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Thanks for the patch! We already have a patch that fixes sparse warnings
(including these) queued up. See:
https://github.com/jpirko/linux_mlxsw/commit/4800ed89f5da55a42a173d5cf9225d4fbb8a96bd

But since we already have one patch under review we've yet to submit it.
https://patchwork.ozlabs.org/patch/670846/

Do you mind dropping this and instead let our patch (with the rest of
the fixes) go through?

Thanks, Ido.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mlxsw: spectrum: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 10:50 +0200
  Re: [PATCH] mlxsw: spectrum: mark symbols static where possible Ido Schimmel <idosch@idosch.org> - 2016-09-18 11:20 +0200

csiph-web