Re: [PATCH] mlxsw: spectrum: mark symbols static where possible

From	Ido Schimmel <idosch@idosch.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mlxsw: spectrum: mark symbols static where possible
Date	2016-09-18 11:20 +0200
Message-ID	<siGqt-6js-3@gated-at.bofh.it> (permalink)
References	<siFXr-5UO-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Sun, Sep 18, 2016 at 04:39:47PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:251:29: warning: no previous prototype for 'mlxsw_sp_span_entry_find' [-Wmissing-prototypes]
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:265:29: warning: no previous prototype for 'mlxsw_sp_span_entry_get' [-Wmissing-prototypes]
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:1749:6: warning: no previous prototype for 'mlxsw_sp_fib_entry_put' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Thanks for the patch! We already have a patch that fixes sparse warnings
(including these) queued up. See:
https://github.com/jpirko/linux_mlxsw/commit/4800ed89f5da55a42a173d5cf9225d4fbb8a96bd

But since we already have one patch under review we've yet to submit it.
https://patchwork.ozlabs.org/patch/670846/

Do you mind dropping this and instead let our patch (with the rest of
the fixes) go through?

Thanks, Ido.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mlxsw: spectrum: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 10:50 +0200
  Re: [PATCH] mlxsw: spectrum: mark symbols static where possible Ido Schimmel <idosch@idosch.org> - 2016-09-18 11:20 +0200

csiph-web