Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483653

Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period

From Richard Cochran <richardcochran@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period
Date 2016-09-14 22:50 +0200
Message-ID <shpi1-5JB-9@gated-at.bofh.it> (permalink)
References (1 earlier) <shi6S-1iq-13@gated-at.bofh.it> <shjmi-1XX-37@gated-at.bofh.it> <shoFj-5qB-15@gated-at.bofh.it> <shoFj-5qB-13@gated-at.bofh.it> <shoYF-5Ck-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 14, 2016 at 11:23:43PM +0300, Grygorii Strashko wrote:
> if yes then those changes are correct as from patch#7 point of 
> view, as from patch#8 because they are separate standalone changes.
> In patch patch#7 it reasonable to ball out earlier, while in patch#8
> it required to move forward a bit as I need to know maxsec. 

And what about the extra blank line?  AFAICT, placing the test later
in patch #7 is correct logic and has the advantage of not distracting
reviews with pointless churn!

Thanks,
Richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] net: ethernet: ti: cpts: update and fixes Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
  [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:30 +0200
      Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:10 +0200
        Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:30 +0200
          Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:50 +0200
            Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:00 +0200
      Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:10 +0200
  [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:30 +0200
      Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:10 +0200
    Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:30 +0200
      Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:00 +0200
        Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-14 23:10 +0200
          Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:20 +0200
      Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-15 14:00 +0200
        Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-15 16:00 +0200
  [PATCH 1/9] net: ethernet: ti: exclude cpts from build when disabled Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
  [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:00 +0200
      Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:20 +0200
        Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:40 +0200
          Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-14 23:00 +0200
            Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:00 +0200
        Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:40 +0200
    Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-15 10:20 +0200
  [PATCH 5/9] net: ethernet: ti: cpts: add return value to tx and rx timestamp funcitons Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 5/9] net: ethernet: ti: cpts: add return value to tx and  rx timestamp funcitons Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:10 +0200
  [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event pool is empty Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if  event pool is empty Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:20 +0200
      Re: [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event  pool is empty Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:00 +0200

csiph-web