Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483906

Re: [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization

From Richard Cochran <richardcochran@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization
Date 2016-09-15 10:20 +0200
Message-ID <shA3L-4yi-1@gated-at.bofh.it> (permalink)
References <shi6S-1iq-7@gated-at.bofh.it> <shi6S-1iq-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 14, 2016 at 04:02:25PM +0300, Grygorii Strashko wrote:
> The current implementation CPTS initialization and deinitialization
> (represented by cpts_register/unregister()) is pretty entangled and
> has some issues, like:
> - ptp clock registered before spinlock, which is protecting it, and
> before timecounter and cyclecounter initialization;
> - CPTS ref_clk requested using devm API while cpts_register() is
> called from .ndo_open(), as result additional checks required;
> - CPTS ref_clk is prepared, but never unprepared;
> - CPTS is not disabled even when unregistered..

This list of four items is a clear sign that this one patch should be
broken into a series of four.

Thanks,
Richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] net: ethernet: ti: cpts: update and fixes Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
  [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:30 +0200
      Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:10 +0200
        Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:30 +0200
          Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:50 +0200
            Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:00 +0200
      Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:10 +0200
  [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:30 +0200
      Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:10 +0200
    Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:30 +0200
      Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:00 +0200
        Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-14 23:10 +0200
          Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:20 +0200
      Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-15 14:00 +0200
        Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from  refclk freq Richard Cochran <richardcochran@gmail.com> - 2016-09-15 16:00 +0200
  [PATCH 1/9] net: ethernet: ti: exclude cpts from build when disabled Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
  [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:00 +0200
      Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:20 +0200
        Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:40 +0200
          Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-14 23:00 +0200
            Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 23:00 +0200
        Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-14 22:40 +0200
    Re: [PATCH 3/9] net: ethernet: ti: cpts: rework  initialization/deinitialization Richard Cochran <richardcochran@gmail.com> - 2016-09-15 10:20 +0200
  [PATCH 5/9] net: ethernet: ti: cpts: add return value to tx and rx timestamp funcitons Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 5/9] net: ethernet: ti: cpts: add return value to tx and  rx timestamp funcitons Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:10 +0200
  [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event pool is empty Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 15:10 +0200
    Re: [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if  event pool is empty Richard Cochran <richardcochran@gmail.com> - 2016-09-14 16:20 +0200
      Re: [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event  pool is empty Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-14 22:00 +0200

csiph-web