Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1483665

Re: [PATCH] random: Fix kernel panic due to system_wq use before init

Path csiph.com!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] random: Fix kernel panic due to system_wq use before init
Date Wed, 14 Sep 2016 23:10:01 +0200
Message-ID <shpBn-665-7@gated-at.bofh.it> (permalink)
References <shnJg-4KO-9@gated-at.bofh.it> <shnSV-4Oc-15@gated-at.bofh.it> <shnSV-4Oc-13@gated-at.bofh.it> <shpBn-665-9@gated-at.bofh.it>
X-Original-To Waiman Long <waiman.long@hpe.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=dJEnpOQkE9YUNWTrx3s1HJ4VfoqrpZ2Brg9AkDRZ0Ik=; b=hQhBgwM/DOSYa8FtOgvIccInR7qOifnHK46BQ6dkQlIiPu94Ja5Q30N1zineX3zNrQ J8a1Npe0+MBWjzTR5D2pozfX112Ofur4DwFcu4BKOdtIkKTX2Mxx+tv6yT5//D02K5J/ 0tm98fG8FTVv+EM4/puLJQlZ1uNC2UN2MCGHFT5rXOGCUlHGF1Dl2Y09leYzygvPx70G sq24CMwQwbxj9zGRR09EwBU1HUTf0/IoCY7sYvSBfvdvfn16bJt+zuo6gkiqgwAhdTt1 PdFW9P+/PCmz699bC1C0QnMy7OwhZxgEoj72gIMXtBZ+x4dzHiTQkLwp7Xy+qPvPXruA YZbw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=dJEnpOQkE9YUNWTrx3s1HJ4VfoqrpZ2Brg9AkDRZ0Ik=; b=dHjF8JX/9SO2bXHmVgpLI5otZKPL/jIq3G+FBKopfS9Dp1sU4Z09K9X/wKKKlNxu8M fR6RyeUZtMOo9he/hmt+ODCtwjgqUwgXWGNGrju1+H04K8dWLw8p40rX6+4R7zvHgjAT zH3YPaNV0HFsazQZ9ronMfNoyKkrgdxKSmvJycWtoJwGIxu8Jkm3ynnYhDXoBB3MkePs AFqBXR5UGzq1svBfL8fnSKdINoiUogTqevWgciw3vH5wecFRtf+NGkKnfjtHeRWF6Z/y B5TmyPtvghAak8LRpcLNriEufi0JBwEXHmHBMoxOGSNh1H6IU3BvJbWZd1SizKtNTK1b ZwSg==
X-Gm-Message-State AE9vXwMey8C3J5haP522od7PCSG6rTMA1SUsNcXQhWIK/0xjDwZUPw1Q9VdtelIFeK75nyCsD/EFjmpCVdnghw==
X-Received by 10.157.17.65 with SMTP id p1mr3856240otp.141.1473887162039; Wed, 14 Sep 2016 14:06:02 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth Ka2l3JuFCXFbTj_6rE-Hithyw1A
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 25
Organization linux.* mail to news gateway
X-Original-Cc "Theodore Ts'o" <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Scott J Norton <scott.norton@hpe.com>, Douglas Hatch <doug.hatch@hpe.com>
X-Original-Date Wed, 14 Sep 2016 14:06:01 -0700
X-Original-Message-ID <CA+55aFyd+Yqz0uhtKCOD2k3JfSA3kGzrAw3+Nc1DQMXOdax=AQ@mail.gmail.com>
X-Original-References <1473879781-23819-1-git-send-email-Waiman.Long@hpe.com> <57D9A1A9.8050506@hpe.com> <CA+55aFwkwUpE1Yg29br6NUt5Y3ggHUR7g3ERHM64J8MBkfrAXQ@mail.gmail.com> <57D9A633.2030904@hpe.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1483665

Show key headers only | View raw


On Wed, Sep 14, 2016 at 12:34 PM, Waiman Long <waiman.long@hpe.com> wrote:
>
> I can try, but the 16-socket system that I have at the moment takes a long
> time (more than an hour) for one shutdown-reboot cycle. It may not be really
> more interrupts in 4.8, it may be that the random driver just somehow run
> very slow on my test machine as it seems to have a major rewrite in the 4.8
> cycle.

Looking at the random driver updates since 4.7, the only thing I see
is that .crng_fast_load() for the chacha20 randomness. And that should
trigger only until it's been initialized, so the cost looks like it
should be limited.

Is there some fundamental reason you think it's the random driver?
Other than the oops? Because I'd be more inclined to suspect just some
apic issue or something, where an actual interrupt line ends up
screaming or whatever. Is this UV? There's also the CPU hotplug state
machine changes etc.

But a few rounds of bisecting should hopefully cut down on the
suspects a lot. A *full* bisect might be 16-17 rounds, but if you can
do just four or five rounds of bisection, that should still cut it
down from 14k commits to "only" several hundred..

               Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] random: Fix kernel panic due to system_wq use before init Waiman Long <Waiman.Long@hpe.com> - 2016-09-14 21:10 +0200
  Re: [PATCH] random: Fix kernel panic due to system_wq use before init Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-14 21:20 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-14 23:10 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 11:30 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 14:50 +0200
      Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 17:00 +0200
        Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-20 16:10 +0200
  Re: [PATCH] random: Fix kernel panic due to system_wq use before init Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-14 21:20 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Tejun Heo <tj@kernel.org> - 2016-09-14 22:00 +0200
      Re: [PATCH] random: Fix kernel panic due to system_wq use before init Tejun Heo <tj@kernel.org> - 2016-09-15 00:30 +0200

csiph-web