Re: [PATCH] random: Fix kernel panic due to system_wq use before init

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] random: Fix kernel panic due to system_wq use before init
Date	2016-09-14 23:10 +0200
Message-ID	<shpBn-665-7@gated-at.bofh.it> (permalink)
References	<shnJg-4KO-9@gated-at.bofh.it> <shnSV-4Oc-15@gated-at.bofh.it> <shnSV-4Oc-13@gated-at.bofh.it> <shpBn-665-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 14, 2016 at 12:34 PM, Waiman Long <waiman.long@hpe.com> wrote:
>
> I can try, but the 16-socket system that I have at the moment takes a long
> time (more than an hour) for one shutdown-reboot cycle. It may not be really
> more interrupts in 4.8, it may be that the random driver just somehow run
> very slow on my test machine as it seems to have a major rewrite in the 4.8
> cycle.

Looking at the random driver updates since 4.7, the only thing I see
is that .crng_fast_load() for the chacha20 randomness. And that should
trigger only until it's been initialized, so the cost looks like it
should be limited.

Is there some fundamental reason you think it's the random driver?
Other than the oops? Because I'd be more inclined to suspect just some
apic issue or something, where an actual interrupt line ends up
screaming or whatever. Is this UV? There's also the CPU hotplug state
machine changes etc.

But a few rounds of bisecting should hopefully cut down on the
suspects a lot. A *full* bisect might be 16-17 rounds, but if you can
do just four or five rounds of bisection, that should still cut it
down from 14k commits to "only" several hundred..

               Linus

Thread

[PATCH] random: Fix kernel panic due to system_wq use before init Waiman Long <Waiman.Long@hpe.com> - 2016-09-14 21:10 +0200
  Re: [PATCH] random: Fix kernel panic due to system_wq use before init Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-14 21:20 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-14 23:10 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 11:30 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 14:50 +0200
      Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 17:00 +0200
        Re: [PATCH] random: Fix kernel panic due to system_wq use before init Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-20 16:10 +0200
  Re: [PATCH] random: Fix kernel panic due to system_wq use before init Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-14 21:20 +0200
    Re: [PATCH] random: Fix kernel panic due to system_wq use before init Tejun Heo <tj@kernel.org> - 2016-09-14 22:00 +0200
      Re: [PATCH] random: Fix kernel panic due to system_wq use before init Tejun Heo <tj@kernel.org> - 2016-09-15 00:30 +0200

csiph-web