Re: perf/x86: Use kmalloc_array() in merge_attr()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: perf/x86: Use kmalloc_array() in merge_attr()
Date	2016-09-14 19:50 +0200
Message-ID	<shmtP-3OB-1@gated-at.bofh.it> (permalink)
References	<sdBB8-88b-19@gated-at.bofh.it> <sdWYW-N5-13@gated-at.bofh.it> <shlxL-3gE-5@gated-at.bofh.it> <shlR7-3Ce-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> Would you like to suggest any more constraints for this kind of
>> software refactoring?
> 
> Yes, don't do it.

I am bit surprised by this feedback.


> If you're writing new code by all means, do whatever you feel,

Could you accept related software updates then?


> but don't go changing code just because checkpatch.

Why is this not a valid reason for you?

How useful can properties that are provided by a function like
kmalloc_array() be also for software modules which you care about?


Do you find any other software improvements more worthwhile?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: perf/x86: Use kmalloc_array() in merge_attr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-14 18:50 +0200
  Re: perf/x86: Use kmalloc_array() in merge_attr() Peter Zijlstra <peterz@infradead.org> - 2016-09-14 19:10 +0200
    Re: perf/x86: Use kmalloc_array() in merge_attr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-14 19:50 +0200

csiph-web