Re: [PATCH v2 11/17] UBI: simplify recover_peb() code

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 11/17] UBI: simplify recover_peb() code
Date	2016-09-16 12:20 +0200
Message-ID	<shYpr-3nl-7@gated-at.bofh.it> (permalink)
References	<se3H3-5qz-3@gated-at.bofh.it> <se3H3-5qz-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Boris,

On 05.09.2016 17:05, Boris Brezillon wrote:
> + * This function is called in case of a write failure and moves all good data
> + * from the potentially bad physical eraseblock to a good physical eraseblock.
> + * This function also writes the data which was not written due to the failure.
> + * Returns 0 in case of success, and a negative error code in case of failure.
> + * This function tries %UBI_IO_RETRIES before giving up.
> + */
> +static int recover_peb(struct ubi_device *ubi, int pnum, int vol_id, int lnum,
> +		       const void *buf, int offset, int len)
> +{
> +	int err, idx = vol_id2idx(ubi, vol_id), tries;
> +	struct ubi_volume *vol = ubi->volumes[idx];
> +	struct ubi_vid_hdr *vid_hdr;
> +
> +	vid_hdr = ubi_zalloc_vid_hdr(ubi, GFP_NOFS);
> +	if (!vid_hdr)
> +		return -ENOMEM;
> +
> +	for (tries = 0; tries <= UBI_IO_RETRIES; tries++) {
> +		err = try_recover_peb(vol, pnum, lnum, buf, offset, len,
> +				      vid_hdr);
> +		if (!err || err == -ENOSPC)
> +			break;

Why do you handle ENOSPC as fatal error? Since the loop is bound by UBI_IO_RETRIES
IMHO we can retry also upon ENOSPC.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 11/17] UBI: simplify recover_peb() code Richard Weinberger <richard@nod.at> - 2016-09-16 12:20 +0200
  Re: [PATCH v2 11/17] UBI: simplify recover_peb() code Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-09-16 13:30 +0200
    Re: [PATCH v2 11/17] UBI: simplify recover_peb() code Richard Weinberger <richard@nod.at> - 2016-09-16 15:30 +0200
      Re: [PATCH v2 11/17] UBI: simplify recover_peb() code Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-09-16 15:30 +0200

csiph-web