Re: [PATCH v3] leds: Introduce userspace leds driver

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] leds: Introduce userspace leds driver
Date	2016-09-16 08:00 +0200
Message-ID	<shUlP-ud-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <sguD8-It-15@gated-at.bofh.it> <sguD8-It-13@gated-at.bofh.it> <shEAp-7rV-19@gated-at.bofh.it> <shGiS-8jb-53@gated-at.bofh.it> <shHRD-ZC-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

> >>>>+    if (copy_from_user(&udev->user_dev, buffer,
> >>>>+               sizeof(struct uleds_user_dev))) {
> >>>>+        ret = -EFAULT;
> >>>>+        goto out;
> >>>>+    }
> >>>>+
> >>>>+    if (!udev->user_dev.name[0]) {
> >>>>+        ret = -EINVAL;
> >>>>+        goto out;
> >>>>+    }
> >>>>+
> >>>>+    ret = led_classdev_register(NULL, &udev->led_cdev);
> >>>>+    if (ret < 0)
> >>>>+        goto out;
> >>
> >>No sanity checking on the name -> probably a security hole. Do not
> >>push this upstream before this is fixed.
> >
> 
> If this is a serious security issue, then you should also raise an issue
> with input maintainers because this is the extent of sanity checking for
> uinput device names as well.

I guess that should be fixed. But lets not add new ones.

> I must confess that I am no security expert, so unless you can give specific
> examples of what potential threats are, I will not be able to guess what I
> need to do to fix it.
> 
> After some digging around the kernel, I don't see many instances of
> validating device node names. The best I have found so far comes from
> create_entry() in binfmt_misc.c
> 
> 	if (!e->name[0] ||
> 	    !strcmp(e->name, ".") ||
> 	    !strcmp(e->name, "..") ||
> 	    strchr(e->name, '/'))
> 		goto einval;
> 
> Would something like this be a sufficient sanity check? I suppose we could
> also check for non-printing characters, but I don't think ignoring them
> would be a security issue.

That would be minimum, yes. I guess it would be better/easier to just
limit the names to [a-zA-Z:-_0-9]*?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

[PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-09 19:00 +0200
  Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-09 22:50 +0200
  Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-12 10:20 +0200
    Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-12 17:00 +0200
    Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-15 15:10 +0200
      Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-15 15:40 +0200
        Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-15 17:00 +0200
          Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:20 +0200
      Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-15 17:00 +0200
        Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-15 17:40 +0200
          Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-15 17:40 +0200
          Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:00 +0200
            Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:40 +0200
          Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:00 +0200
            Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:20 +0200
          Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:10 +0200
            Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:50 +0200
        Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-15 18:40 +0200
          Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:00 +0200
            Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-16 09:10 +0200
              Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:20 +0200
                Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 21:40 +0200

csiph-web