Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484273
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] leds: Introduce userspace leds driver |
| Date | 2016-09-15 17:00 +0200 |
| Message-ID | <shGiS-8jb-41@gated-at.bofh.it> (permalink) |
| References | <sfxjH-5u3-13@gated-at.bofh.it> <sguD8-It-15@gated-at.bofh.it> <sguD8-It-13@gated-at.bofh.it> <shEAp-7rV-19@gated-at.bofh.it> <shF3r-7Ca-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Pavel,
On 09/15/2016 03:35 PM, Pavel Machek wrote:
> Hi!
>
>>>> + if (copy_from_user(&udev->user_dev, buffer,
>>>> + sizeof(struct uleds_user_dev))) {
>>>> + ret = -EFAULT;
>>>> + goto out;
>>>> + }
>>>> +
>>>> + if (!udev->user_dev.name[0]) {
>>>> + ret = -EINVAL;
>>>> + goto out;
>>>> + }
>>>> +
>>>> + ret = led_classdev_register(NULL, &udev->led_cdev);
>>>> + if (ret < 0)
>>>> + goto out;
>>
>> No sanity checking on the name -> probably a security hole. Do not
>> push this upstream before this is fixed.
>
> And actually... is it possible to have more then one userspace LED
> with this interface? I do have RGB LED connect on /dev/ttyUSB0, and I
> guess userspace driver would be appropriate, but it needs 3
> channels...
Each new successful write to /dev/uleds creates a new LED class device.
See Documentation/leds/uleds.txt.
--
Best regards,
Jacek Anaszewski
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-09 19:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-09 22:50 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-12 10:20 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-12 17:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-15 15:10 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-15 15:40 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-15 17:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:20 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-15 17:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-15 17:40 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-15 17:40 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:40 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:20 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:10 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:50 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-15 18:40 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 08:00 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-16 09:10 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver David Lechner <david@lechnology.com> - 2016-09-16 17:20 +0200
Re: [PATCH v3] leds: Introduce userspace leds driver Pavel Machek <pavel@ucw.cz> - 2016-09-16 21:40 +0200
csiph-web