Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484499

[PATCH 7/7] workqueue: remove keventd_up()

Show all headers | View raw

keventd_up() no longer has in-kernel users.  Remove it and make
wq_online static.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 include/linux/workqueue.h | 10 ----------
 kernel/workqueue.c        |  2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 91d416f..5641713 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -358,8 +358,6 @@ extern struct workqueue_struct *system_freezable_wq;
 extern struct workqueue_struct *system_power_efficient_wq;
 extern struct workqueue_struct *system_freezable_power_efficient_wq;
 
-extern bool wq_online;
-
 extern struct workqueue_struct *
 __alloc_workqueue_key(const char *fmt, unsigned int flags, int max_active,
 	struct lock_class_key *key, const char *lock_name, ...) __printf(1, 6);
@@ -591,14 +589,6 @@ static inline bool schedule_delayed_work(struct delayed_work *dwork,
 	return queue_delayed_work(system_wq, dwork, delay);
 }
 
-/**
- * keventd_up - is workqueue initialized yet?
- */
-static inline bool keventd_up(void)
-{
-	return wq_online;
-}
-
 #ifndef CONFIG_SMP
 static inline long work_on_cpu(int cpu, long (*fn)(void *), void *arg)
 {
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index a05ab14..3bef80a 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -290,7 +290,7 @@ module_param_named(disable_numa, wq_disable_numa, bool, 0444);
 static bool wq_power_efficient = IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT);
 module_param_named(power_efficient, wq_power_efficient, bool, 0444);
 
-bool wq_online;				/* can kworkers be created yet? */
+static bool wq_online;			/* can kworkers be created yet? */
 
 static bool wq_numa_enabled;		/* unbound NUMA affinity enabled */
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET wq/for-4.9] workqueue: make workqueue available very early during boot Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
  [PATCH 2/7] mce, workqueue: remove keventd_up() usage Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
    Re: [PATCH 2/7] mce, workqueue: remove keventd_up() usage Borislav Petkov <bp@alien8.de> - 2016-09-17 10:00 +0200
      Re: [PATCH 2/7] mce, workqueue: remove keventd_up() usage Tejun Heo <tj@kernel.org> - 2016-09-17 19:30 +0200
        Re: [PATCH 2/7] mce, workqueue: remove keventd_up() usage Borislav Petkov <bp@alien8.de> - 2016-09-17 22:30 +0200
  [PATCH 5/7] slab, workqueue: remove keventd_up() usage Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
    Re: [PATCH 5/7] slab, workqueue: remove keventd_up() usage Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-09-22 10:10 +0200
  [PATCH 7/7] workqueue: remove keventd_up() Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
  [PATCH 1/7] workqueue: make workqueue available early during boot Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
    [PATCH v2 1/7] workqueue: make workqueue available early during boot Tejun Heo <tj@kernel.org> - 2016-09-17 19:30 +0200
  Re: [PATCHSET wq/for-4.9] workqueue: make workqueue available very  early during boot Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-15 22:00 +0200
  Re: [PATCHSET wq/for-4.9] workqueue: make workqueue available very  early during boot Tejun Heo <tj@kernel.org> - 2016-09-16 22:00 +0200

csiph-web