Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484497

[PATCH 5/7] slab, workqueue: remove keventd_up() usage

Show all headers | View raw

Now that workqueue can handle work item queueing from very early
during boot, there is no need to gate schedule_delayed_work_on() while
!keventd_up().  Remove it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
Hello,

This change depends on an earlier workqueue patch and is followed by a
patch to remove keventd_up().  It'd be great if it can be routed
through the wq/for-4.9 branch.

Thanks.

 mm/slab.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index b672710..dc69b6b 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -550,12 +550,7 @@ static void start_cpu_timer(int cpu)
 {
 	struct delayed_work *reap_work = &per_cpu(slab_reap_work, cpu);
 
-	/*
-	 * When this gets called from do_initcalls via cpucache_init(),
-	 * init_workqueues() has already run, so keventd will be setup
-	 * at that time.
-	 */
-	if (keventd_up() && reap_work->work.func == NULL) {
+	if (reap_work->work.func == NULL) {
 		init_reap_node(cpu);
 		INIT_DEFERRABLE_WORK(reap_work, cache_reap);
 		schedule_delayed_work_on(cpu, reap_work,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET wq/for-4.9] workqueue: make workqueue available very early during boot Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
  [PATCH 2/7] mce, workqueue: remove keventd_up() usage Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
    Re: [PATCH 2/7] mce, workqueue: remove keventd_up() usage Borislav Petkov <bp@alien8.de> - 2016-09-17 10:00 +0200
      Re: [PATCH 2/7] mce, workqueue: remove keventd_up() usage Tejun Heo <tj@kernel.org> - 2016-09-17 19:30 +0200
        Re: [PATCH 2/7] mce, workqueue: remove keventd_up() usage Borislav Petkov <bp@alien8.de> - 2016-09-17 22:30 +0200
  [PATCH 5/7] slab, workqueue: remove keventd_up() usage Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
    Re: [PATCH 5/7] slab, workqueue: remove keventd_up() usage Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-09-22 10:10 +0200
  [PATCH 7/7] workqueue: remove keventd_up() Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
  [PATCH 1/7] workqueue: make workqueue available early during boot Tejun Heo <tj@kernel.org> - 2016-09-15 21:40 +0200
    [PATCH v2 1/7] workqueue: make workqueue available early during boot Tejun Heo <tj@kernel.org> - 2016-09-17 19:30 +0200
  Re: [PATCHSET wq/for-4.9] workqueue: make workqueue available very  early during boot Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-15 22:00 +0200
  Re: [PATCHSET wq/for-4.9] workqueue: make workqueue available very  early during boot Tejun Heo <tj@kernel.org> - 2016-09-16 22:00 +0200

csiph-web