Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481251

Re: [PATCH] net: r6040: add in missing white space in error message text

Show key headers only | View raw

Hello.

On 9/12/2016 3:08 PM, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> A couple of dev_err messages span two lines and the literal
> string is missing a white space between words. Add the white
> space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/rdc/r6040.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
> index cb29ee2..5dc655b 100644
> --- a/drivers/net/ethernet/rdc/r6040.c
> +++ b/drivers/net/ethernet/rdc/r6040.c
> @@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	/* this should always be supported */
>  	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
>  	if (err) {
> -		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> +		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
>  				"not supported by the card\n");
>  		goto err_out_disable_dev;
>  	}
>  	err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
>  	if (err) {
> -		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> +		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
>  				"not supported by the card\n");
>  		goto err_out_disable_dev;
>  	}

    The message strings simply shouldn't be broken up, and checkpatch.pl knows 
about that.

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: r6040: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 14:20 +0200
  Re: [PATCH] net: r6040: add in missing white space in error message  text Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-12 15:10 +0200

csiph-web