Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481203 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-12 14:20 +0200 |
| Last post | 2016-09-12 15:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: r6040: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 14:20 +0200
Re: [PATCH] net: r6040: add in missing white space in error message text Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-12 15:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 14:20 +0200 |
| Subject | [PATCH] net: r6040: add in missing white space in error message text |
| Message-ID | <sgynn-3cm-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
A couple of dev_err messages span two lines and the literal
string is missing a white space between words. Add the white
space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/rdc/r6040.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index cb29ee2..5dc655b 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
/* this should always be supported */
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
if (err) {
- dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+ dev_err(&pdev->dev, "32-bit PCI DMA addresses "
"not supported by the card\n");
goto err_out_disable_dev;
}
err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
if (err) {
- dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+ dev_err(&pdev->dev, "32-bit PCI DMA addresses "
"not supported by the card\n");
goto err_out_disable_dev;
}
--
2.9.3
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-09-12 15:10 +0200 |
| Subject | Re: [PATCH] net: r6040: add in missing white space in error message text |
| Message-ID | <sgz9M-3JB-43@gated-at.bofh.it> |
| In reply to | #1481203 |
Hello.
On 9/12/2016 3:08 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A couple of dev_err messages span two lines and the literal
> string is missing a white space between words. Add the white
> space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/rdc/r6040.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
> index cb29ee2..5dc655b 100644
> --- a/drivers/net/ethernet/rdc/r6040.c
> +++ b/drivers/net/ethernet/rdc/r6040.c
> @@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* this should always be supported */
> err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> if (err) {
> - dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> + dev_err(&pdev->dev, "32-bit PCI DMA addresses "
> "not supported by the card\n");
> goto err_out_disable_dev;
> }
> err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
> if (err) {
> - dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> + dev_err(&pdev->dev, "32-bit PCI DMA addresses "
> "not supported by the card\n");
> goto err_out_disable_dev;
> }
The message strings simply shouldn't be broken up, and checkpatch.pl knows
about that.
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web