Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482592
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support |
| Date | 2016-09-13 17:30 +0200 |
| Message-ID | <sgXOO-3H6-35@gated-at.bofh.it> (permalink) |
| References | <sfvhU-4gq-7@gated-at.bofh.it> <sfvhU-4gq-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 9 Sep 2016, Alexandre TORGUE wrote:
> +static void stm32_exti_free(struct irq_domain *d, unsigned int virq,
> + unsigned int nr_irqs)
> +{
> + struct irq_data *data = irq_get_irq_data(virq);
> +
> + irq_gc_mask_clr_bit(data->parent_data);
I have a hard time to understand this. The irq domain is not hierarchical.
> + irq_domain_reset_irq_data(data);
> + domain = irq_domain_add_linear(node, nr_exti,
> + &irq_exti_domain_ops, NULL);
It's a simple linear domain. So how can data->parent_data be a valid
irq_data pointer? Answer: It can't!
But it doesn't blow up in your face simply because the alloc/free callbacks
are never invoked for simple non hierarchical domains. So you should have
removed that stuff after copying some other irqchip driver.
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Marc Zyngier <marc.zyngier@arm.com> - 2016-09-13 10:20 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-13 17:30 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-13 18:40 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-14 11:30 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-14 15:10 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-14 15:40 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-14 15:50 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-20 11:50 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 12:00 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-20 14:50 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 14:50 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-20 15:40 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 16:10 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-20 17:30 +0200
Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 18:10 +0200
csiph-web