Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482423
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Colin Ian King <colin.king@canonical.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage |
| Date | Tue, 13 Sep 2016 14:50:01 +0200 |
| Message-ID | <sgVjX-1TH-1@gated-at.bofh.it> (permalink) |
| References | <sfpvP-wL-1@gated-at.bofh.it> <sgzMt-3XR-15@gated-at.bofh.it> <sgNcK-4Tl-13@gated-at.bofh.it> <sgVai-1PB-13@gated-at.bofh.it> <sgVjX-1TH-3@gated-at.bofh.it> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 16 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Phil Reid <preid@electromag.com.au>, Alexandre Courbot <gnurou@gmail.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Tue, 13 Sep 2016 13:45:29 +0100 |
| X-Original-Message-ID | <5e5928e0-7a7a-915e-1090-726cc502f3ce@canonical.com> |
| X-Original-References | <20160909083154.26442-1-colin.king@canonical.com> <CACRpkdYHRjUoANEibzexrmGQiVHL4cgYWZPr6H-_GA1HqqpTNw@mail.gmail.com> <944b682f-6217-f759-7429-339274cd5894@electromag.com.au> <18457294.js4cyg49EU@wuerfel> <CACRpkdZOd2qeCCvC3f0n4SZtmt9PQMOyOGuyS7Oio6qLRc+0vQ@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1482423 |
Show key headers only | View raw
On 13/09/16 13:46, Linus Walleij wrote: > On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann <arnd@arndb.de> wrote: > >> Please try to avoid adding initializations in the local variable >> declaration, they just hide otherwise useful warnings when >> you get a function that actually does something incorrect >> in some code paths. > > Agreed, sorry for my ignorance :( > > I duly corrected the git and reverted the other patch instead of yours. > > Yours, > Linus Walleij > Makes sense. Thanks Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-12 15:50 +0200
Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Phil Reid <preid@electromag.com.au> - 2016-09-13 06:10 +0200
Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 13:50 +0200
Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Arnd Bergmann <arnd@arndb.de> - 2016-09-13 14:40 +0200
Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Colin Ian King <colin.king@canonical.com> - 2016-09-13 14:50 +0200
Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 14:50 +0200
csiph-web