Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions
Date	2016-09-13 10:40 +0200
Message-ID	<sgRq1-7PG-17@gated-at.bofh.it> (permalink)
References	<sgBuX-58A-53@gated-at.bofh.it> <sgDGq-6uu-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 12, 2016 at 07:52:08PM +0200, Pavel Machek wrote:
> On Mon 2016-09-12 17:32:57, Arnd Bergmann wrote:
> > The new ad5820 driver uses #ifdef to hide the suspend/resume functions,
> > but gets it wrong when CONFIG_PM_SLEEP is disabled:
> > 
> > drivers/media/i2c/ad5820.c:286:12: error: 'ad5820_resume' defined but not used [-Werror=unused-function]
> > drivers/media/i2c/ad5820.c:274:12: error: 'ad5820_suspend' defined but not used [-Werror=unused-function]
> > 
> > This replaces the #ifdef with a __maybe_unused annotation that is
> > simpler and harder to get wrong, avoiding the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus
> coil")
> 
> Thanks!
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks, Arnd and Pavel!

Added to my ad5820 branch.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Arnd Bergmann <arnd@arndb.de> - 2016-09-12 17:40 +0200
  Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Pavel Machek <pavel@ucw.cz> - 2016-09-12 20:00 +0200
    Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Sakari Ailus <sakari.ailus@iki.fi> - 2016-09-13 10:40 +0200

csiph-web