Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481770

Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions

Show all headers | View raw

On Mon 2016-09-12 17:32:57, Arnd Bergmann wrote:
> The new ad5820 driver uses #ifdef to hide the suspend/resume functions,
> but gets it wrong when CONFIG_PM_SLEEP is disabled:
> 
> drivers/media/i2c/ad5820.c:286:12: error: 'ad5820_resume' defined but not used [-Werror=unused-function]
> drivers/media/i2c/ad5820.c:274:12: error: 'ad5820_suspend' defined but not used [-Werror=unused-function]
> 
> This replaces the #ifdef with a __maybe_unused annotation that is
> simpler and harder to get wrong, avoiding the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus
coil")

Thanks!

Acked-by: Pavel Machek <pavel@ucw.cz>


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Arnd Bergmann <arnd@arndb.de> - 2016-09-12 17:40 +0200
  Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Pavel Machek <pavel@ucw.cz> - 2016-09-12 20:00 +0200
    Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Sakari Ailus <sakari.ailus@iki.fi> - 2016-09-13 10:40 +0200

csiph-web