Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480182

Re: Regulator probe

From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: Regulator probe
Date 2016-09-09 18:20 +0200
Message-ID <sfwGZ-5gP-7@gated-at.bofh.it> (permalink)
References (5 earlier) <selXj-PI-5@gated-at.bofh.it> <seMb8-WB-7@gated-at.bofh.it> <sfsWJ-2Il-5@gated-at.bofh.it> <sftzr-2Vd-5@gated-at.bofh.it> <sfw4h-4M9-11@gated-at.bofh.it>
Organization Intel Finland Oy

Show all headers | View raw

On Fri, 2016-09-09 at 16:29 +0100, Mark Brown wrote:

> > Fixed regulator probe is deferred:
> 
> > 
> > reg-fixed-voltage reg-fixed-voltage.0.auto: Failed to register
> > regulator: -517
> 
> So the regulator probe *does* get deferred as expected...
> 
> > 
> > But:
> > sdhci-pci 0000:00:01.3: No vmmc regulator found
> 
> > 
> > Code in sdhci driver is:
> >         ret = mmc_regulator_get_supply(mmc);
> >         if (ret == -EPROBE_DEFER)
> >                 return ret;
> > 
> > mmc_regulator_get_supply():
> > ...
> >         mmc->supply.vmmc = devm_regulator_get_optional(dev, "vmmc");
> >         mmc->supply.vqmmc = devm_regulator_get_optional(dev,
> > "vqmmc");
> 
> ...and then we correctly report that the optional supply that isn't
> mapped (as far as I remember) isn't there.

But it *will be* soon there.

Hmm... And the proper fix for this case is... (let's assume there will
not be device tree solution in nearest future)?

If I remove has_full_constraints() call I will get EPROBE_DEFER on all
optional regulators IIRC.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-01 17:00 +0200
  Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-01 17:40 +0200
    Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-01 18:30 +0200
      Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-02 00:10 +0200
        Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-05 18:10 +0200
          Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-06 12:40 +0200
            Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-07 16:40 +0200
              Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-09 14:20 +0200
                Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-09 15:00 +0200
                Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-09 17:40 +0200
                Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-09 18:20 +0200
                Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-09 18:40 +0200
                Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-09 19:10 +0200
                Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-09 19:20 +0200
                Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-10 13:10 +0200
                Re: Regulator probe Mark Brown <broonie@kernel.org> - 2016-09-12 17:30 +0200
                Re: Regulator probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-12 18:10 +0200

csiph-web