Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480145

Re: [RFC PATCH 0/4] Reduce tree_lock contention during swap and reclaim of a single file v1

Show all headers | View raw

On Fri, Sep 9, 2016 at 2:59 AM, Mel Gorman <mgorman@techsingularity.net> wrote:
>
> The progression of this series has been unsatisfactory.

Yeah, I have to say that I particularly don't like patch #1. It's some
rather nasty complexity for dubious gains, and holding the lock for
longer times might have downsides.

And the numbers seem to not necessarily be in favor of patch #3
either, which I would have otherwise been predisposed to like (ie it
looks fairly targeted and not very complex).

#2 seems trivially correct but largely irrelevant.

So I think this series is one of those "we need to find that it makes
a big positive impact" to make sense.

              Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/4] Reduce tree_lock contention during swap and reclaim of a single file v1 Mel Gorman <mgorman@techsingularity.net> - 2016-09-09 12:00 +0200
  [PATCH 2/4] block, brd: Treat storage as non-rotational Mel Gorman <mgorman@techsingularity.net> - 2016-09-09 12:10 +0200
  [PATCH 3/4] mm, vmscan: Stall kswapd if contending on tree_lock Mel Gorman <mgorman@techsingularity.net> - 2016-09-09 12:10 +0200
  [PATCH 1/4] mm, vmscan: Batch removal of mappings under a single lock during reclaim Mel Gorman <mgorman@techsingularity.net> - 2016-09-09 12:10 +0200
    Re: [PATCH 1/4] mm, vmscan: Batch removal of mappings under a single  lock during reclaim Peter Zijlstra <peterz@infradead.org> - 2016-09-16 15:30 +0200
      Re: [PATCH 1/4] mm, vmscan: Batch removal of mappings under a single  lock during reclaim Peter Zijlstra <peterz@infradead.org> - 2016-09-16 16:10 +0200
      Re: [PATCH 1/4] mm, vmscan: Batch removal of mappings under a single  lock during reclaim Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-16 20:40 +0200
        Re: [PATCH 1/4] mm, vmscan: Batch removal of mappings under a single  lock during reclaim Peter Zijlstra <peterz@infradead.org> - 2016-09-17 03:40 +0200
  [PATCH 4/4] mm, vmscan: Potentially stall direct reclaimers on tree_lock contention Mel Gorman <mgorman@techsingularity.net> - 2016-09-09 12:10 +0200
  Re: [RFC PATCH 0/4] Reduce tree_lock contention during swap and  reclaim of a single file v1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-09 17:40 +0200
    Re: [RFC PATCH 0/4] Reduce tree_lock contention during swap and  reclaim of a single file v1 Mel Gorman <mgorman@techsingularity.net> - 2016-09-09 18:20 +0200
      Re: [RFC PATCH 0/4] Reduce tree_lock contention during swap and reclaim of a single file v1 "Huang\, Ying" <ying.huang@intel.com> - 2016-09-09 20:20 +0200

csiph-web