Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480030

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

Show all headers | View raw

> +The device node referenced by "phy" or "phy-handle" should be a child node
> +of this node. See phy.txt for the generic PHY bindings.

I've not looked at the code yet, but is this really true? Generally
there is not this limitation. You can point to any Ethernet phy
anyway, so long as it is on am MDIO bus.

> +
> +Optional properties:
> +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0)
> +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0)
> +
> +The TX/RX clock delay chain settings are board specific.
> +
> +Optional properties for "allwinner,sun8i-h3-emac":
> +- allwinner,leds-active-low: EPHY LEDs are active low
> +
> +Example:
> +
> +emac: ethernet@01c0b000 {
> +	compatible = "allwinner,sun8i-h3-emac";
> +	syscon = <&syscon>;
> +	reg = <0x01c0b000 0x104>;
> +	reg-names = "emac";
> +	interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> +	resets = <&ccu RST_BUS_EMAC>, <<&ccu RST_BUS_EPHY>;
> +	reset-names = "ahb", "ephy";
> +	clocks = <&ccu CLK_BUS_EMAC>, <&ccu CLK_BUS_EPHY>;
> +	clock-names = "ahb", "ephy";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	phy = <&phy1>;

ethernet.txt say:

- phy: the same as "phy-handle" property, not recommended for new bindings.

This is a new binding, please don't support it.

> +	phy-mode = "mii";
> +	allwinner,leds-active-low;
> +
> +	phy1: ethernet-phy@1 {
> +		reg = <1>;
> +	};

It is normal to place these phy nodes inside an container node called
mdio.

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
  [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:30 +0200
      Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-14 11:00 +0200
  [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon  control module Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:30 +0200
      Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon  control module LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200
  [PATCH v3 6/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
  [PATCH v3 2/9] MAINTAINERS: Add myself as maintainer of sun8i-emac Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
  [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 22:50 +0200
      Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-14 16:10 +0200
        Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-17 15:50 +0200
        Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Florian Fainelli <f.fainelli@gmail.com> - 2016-09-17 19:00 +0200
  [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on  sunxi_defconfig Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:40 +0200
      Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on  sunxi_defconfig LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:50 +0200
  [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-09 16:10 +0200
      Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-12 17:10 +0200
        Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-12 17:20 +0200
    Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-09 16:20 +0200
      Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200
        Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-13 16:20 +0200
  Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver Andrew Lunn <andrew@lunn.ch> - 2016-09-09 16:20 +0200
    Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200
  Re: [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver David Miller <davem@davemloft.net> - 2016-09-10 06:00 +0200

csiph-web