Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module
Date	2016-09-12 09:30 +0200
Message-ID	<sgtQJ-ct-3@gated-at.bofh.it> (permalink)
References	<sftpM-2S8-9@gated-at.bofh.it> <sftpM-2S8-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote:
> This patch add the dt node for the syscon register present on the
> Allwinner H3.
> 
> Only two register are present in this syscon and the only one useful is
> the one dedicated to EMAC clock.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index fdf9fdb..a39da6f 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -140,6 +140,11 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		syscon: syscon@01c00000 {
> +			compatible = "syscon";

Having our compatible would be nice here. syscon doesn't mean anything
by itself.

> +			reg = <0x01c00000 0x34>;

And the size of our system controller is 0x1000

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon  control module Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:30 +0200
  Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon  control module LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200

csiph-web