[PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
Date	2016-09-09 10:40 +0200
Message-ID	<sfpvP-wL-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

ret is not initialized so it contains garbage.  Ensure garbage
is not returned in the case that pdata && pdata->teardown is false
by initializing ret to 0.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpio/gpio-pca953x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index cbe2824..52f3d5c 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -845,7 +845,7 @@ static int pca953x_remove(struct i2c_client *client)
 {
 	struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct pca953x_chip *chip = i2c_get_clientdata(client);
-	int ret;
+	int ret = 0;
 
 	if (pdata && pdata->teardown) {
 		ret = pdata->teardown(client, chip->gpio_chip.base,
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Colin King <colin.king@canonical.com> - 2016-09-09 10:40 +0200
  Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-12 15:50 +0200
    Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning  garbage Phil Reid <preid@electromag.com.au> - 2016-09-13 06:10 +0200
      Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 13:50 +0200
      Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Arnd Bergmann <arnd@arndb.de> - 2016-09-13 14:40 +0200
        Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning  garbage Colin Ian King <colin.king@canonical.com> - 2016-09-13 14:50 +0200
        Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 14:50 +0200

csiph-web