Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480508
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86: squash lines for simple wrapper functions |
| Date | 2016-09-10 08:00 +0200 |
| Message-ID | <sfJux-4CL-9@gated-at.bofh.it> (permalink) |
| References | <semJH-1kY-7@gated-at.bofh.it> <sf1a9-2fT-7@gated-at.bofh.it> <sfvhU-4gq-27@gated-at.bofh.it> <sfIf8-3Yu-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 10 Sep 2016, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > > * Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> > > > static unsigned long set_apic_id(unsigned int id)
> > > > {
> > > > - unsigned long x;
> > > > -
> > > > /* maskout x2apic_extra_bits ? */
> > > > - x = id;
> > > > - return x;
> > > > + return id;
> > > > }
> > >
> > > This was clearly left there to document a quirk and as a placeholder for future
> > > changes.
> >
> > Keeping the comment and rewording it to:
> >
> > /* CHECKME: Do we need to mask out the xapic extra bits */
> >
> > should be good enough. The variable dance is not really giving any value.
>
> Yeah, sure - my point was that the mindless removal is wrong.
He kept the comment. The rewording is a bonus.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] x86: squash lines for simple wrapper functions Thomas Gleixner <tglx@linutronix.de> - 2016-09-09 16:50 +0200
Re: [PATCH] x86: squash lines for simple wrapper functions Ingo Molnar <mingo@kernel.org> - 2016-09-10 06:40 +0200
Re: [PATCH] x86: squash lines for simple wrapper functions Thomas Gleixner <tglx@linutronix.de> - 2016-09-10 08:00 +0200
Re: [PATCH] x86: squash lines for simple wrapper functions Ingo Molnar <mingo@kernel.org> - 2016-09-10 11:20 +0200
csiph-web