Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480503

Re: [PATCH] x86: squash lines for simple wrapper functions

Show all headers | View raw

* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > * Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> > >  static unsigned long set_apic_id(unsigned int id)
> > >  {
> > > -	unsigned long x;
> > > -
> > >  	/* maskout x2apic_extra_bits ? */
> > > -	x = id;
> > > -	return x;
> > > +	return id;
> > >  }
> > 
> > This was clearly left there to document a quirk and as a placeholder for future 
> > changes.
> 
> Keeping the comment and rewording it to:
> 
> 	/* CHECKME: Do we need to mask out the xapic extra bits */
> 
> should be good enough. The variable dance is not really giving any value.

Yeah, sure - my point was that the mindless removal is wrong.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86: squash lines for simple wrapper functions Thomas Gleixner <tglx@linutronix.de> - 2016-09-09 16:50 +0200
  Re: [PATCH] x86: squash lines for simple wrapper functions Ingo Molnar <mingo@kernel.org> - 2016-09-10 06:40 +0200
    Re: [PATCH] x86: squash lines for simple wrapper functions Thomas Gleixner <tglx@linutronix.de> - 2016-09-10 08:00 +0200
      Re: [PATCH] x86: squash lines for simple wrapper functions Ingo Molnar <mingo@kernel.org> - 2016-09-10 11:20 +0200

csiph-web