Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477798

Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 06, 2016 at 11:04:38AM +0800, Chen-Yu Tsai wrote:
> On Tue, Sep 6, 2016 at 3:31 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi Jorik,
> >
> > On Sat, Sep 03, 2016 at 02:09:32PM +0200, Jorik Jonker wrote:
> >> On Fri, Sep 02, 2016 at 09:04:25AM +0200, Maxime Ripard wrote:
> >> >Unfortunately, these pins can be used for other purposes as well, so
> >> >we cannot make force that decision down to our users.
> >>
> >> Yes, but since the associated peripheral is disabled, the users are free to
> >> configure other functions/peripherals, right? I mean something like this in
> >> pseudo-DT:
> >>
> >> /soc/pio: pinctrl@01c20800/uart1_pins:
> >>   allwinner,pins = "PG6, PG7";
> >> /soc/pio: pinctrl@01c20800/foo0_pins:
> >>   allwinner,pins = "PG6, PG7";
> >>   ..
> >> /soc/uart1: serial@serial@01c28400:
> >>   pinctrl-0 = <&uart1_pins>;
> >>   status = "disabled";
> >> /soc/bar:
> >>   pinctrl-0 = <&uart1_pins>;
> >>   status = "disabled";
> >>
> >> Assuming Linux/DT allows this, this would force nothing, only offer choice
> >> and ease of use.
> >
> > Hmm, sorry, I went over your patches too quickly...
> >
> > That's a great compromise I think. Chen-Yu, any opinion on this?
> 
> In short, I'm ok with it. But please put an explicit
> 
>     status = "disabled";
> 
> and probably a comment about how/where the peripheral can be
> used in the board dts.
> 
> I intended to do this for the Banana Pis. Though my original plan
> was to enable Raspberry Pi compatible peripherals by default, and
> list the other peripherals that are defined by the vendor as
> "disabled".
> 
> "Defined by the vendor" means that the vendor has some sort of
> document associating the gpio header pins with the peripherals,
> as shown in:
> 
>     http://www.orangepi.org/Docs/Pindefinition.html#CON3_Definition
> 
> This should make it easier for the average user to enable the
> peripherals. I'm not sure we should list _all_ possible ones
> though. That would make the list very large, and some might
> end up never being used.

Having a clear limit on what we can put and what we can't isn't very
easy to do though. Any suggestion on how we can solve that?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] dts: sun8i: add extra uart/i2c to H3 jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals jorik@kippendief.biz - 2016-08-31 21:40 +0200
    Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals Chen-Yu Tsai <wens@csie.org> - 2016-09-01 04:50 +0200
      Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals Jorik Jonker <jorik@kippendief.biz> - 2016-09-01 08:40 +0200
      Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals Chen-Yu Tsai <wens@csie.org> - 2016-09-01 08:50 +0200
  [PATCH v2 5/7] dts: sun8i-h3: add UART1-3 to Orange Pi PC jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 7/7] dts: sun8i-h3: add I2C0-1 to Orange Pi PC jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus jorik@kippendief.biz - 2016-08-31 21:40 +0200
    Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-02 09:10 +0200
      Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Jorik Jonker <jorik@kippendief.biz> - 2016-09-03 14:10 +0200
        Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-05 21:40 +0200
          Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Chen-Yu Tsai <wens@csie.org> - 2016-09-06 05:10 +0200
            Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Jorik Jonker <jorik@kippendief.biz> - 2016-09-06 11:00 +0200
              Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 22:10 +0200
            Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 22:10 +0200
  [PATCH v2 6/7] dts: sun8i-h3: add I2C0-1 to Orange Pi Plus jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 2/7] dts: sun8i-h3: add pinmux definitions for i2c0/i2c1 jorik@kippendief.biz - 2016-08-31 21:40 +0200
    Re: [PATCH v2 2/7] dts: sun8i-h3: add pinmux definitions for i2c0/i2c1 Chen-Yu Tsai <wens@csie.org> - 2016-09-01 04:50 +0200

csiph-web