Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474086

Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals

Show all headers | View raw

Hi,

(trying again in plaintext, sorry for the HTML spam...)

A bit tricky to reply to two mails in one, as I think my reply relates
to both, but here it goes.

On 1 September 2016 at 04:42, Chen-Yu Tsai <wens@csie.org> wrote:
> On Thu, Sep 1, 2016 at 3:30 AM,  <jorik@kippendief.biz> wrote:
>> From: Jorik Jonker <jorik@kippendief.biz>
>>
>> This enables the i2c0/i2c1 peripherals of the SoC. There is actually a third
>> controller, but I do not have a board on hands on which i2c2 is exposed in such
>> a way that I can verify that it works.
>
> If they are listed in the manual, and the interrupts, clocks, resets, pins
> all exist, that is good enough for me.

That sounds sensible, I will do that in v3.

> These pinmuxes are the only ones possible for each peripheral.
> Please drop the _a suffix and the @0 address for both of them.

Agreed. But: I think the same goes for UARTs 0-3, of which 0-1 have a pinmux
following the _a / @0 syntax in current kernel. There are not really options
here, except leaving out RTS/CTS on uarts1-3, which one could do in a
board-specific pinmux.

Moreover, I could put all the pinmux-peripheral associations for H3 in the DTSI,
removing them from the DTS files (including already existing), as the
associations themselves are not really board specific, right?

Best,
Jorik

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] dts: sun8i: add extra uart/i2c to H3 jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals jorik@kippendief.biz - 2016-08-31 21:40 +0200
    Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals Chen-Yu Tsai <wens@csie.org> - 2016-09-01 04:50 +0200
      Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals Jorik Jonker <jorik@kippendief.biz> - 2016-09-01 08:40 +0200
      Re: [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals Chen-Yu Tsai <wens@csie.org> - 2016-09-01 08:50 +0200
  [PATCH v2 5/7] dts: sun8i-h3: add UART1-3 to Orange Pi PC jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 7/7] dts: sun8i-h3: add I2C0-1 to Orange Pi PC jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus jorik@kippendief.biz - 2016-08-31 21:40 +0200
    Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-02 09:10 +0200
      Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Jorik Jonker <jorik@kippendief.biz> - 2016-09-03 14:10 +0200
        Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-05 21:40 +0200
          Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Chen-Yu Tsai <wens@csie.org> - 2016-09-06 05:10 +0200
            Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Jorik Jonker <jorik@kippendief.biz> - 2016-09-06 11:00 +0200
              Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 22:10 +0200
            Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 22:10 +0200
  [PATCH v2 6/7] dts: sun8i-h3: add I2C0-1 to Orange Pi Plus jorik@kippendief.biz - 2016-08-31 21:40 +0200
  [PATCH v2 2/7] dts: sun8i-h3: add pinmux definitions for i2c0/i2c1 jorik@kippendief.biz - 2016-08-31 21:40 +0200
    Re: [PATCH v2 2/7] dts: sun8i-h3: add pinmux definitions for i2c0/i2c1 Chen-Yu Tsai <wens@csie.org> - 2016-09-01 04:50 +0200

csiph-web