Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon
Date	Tue, 06 Sep 2016 17:20:01 +0200
Message-ID	<seqkh-3Gd-9@gated-at.bofh.it> (permalink)
References	<sepRf-3ha-5@gated-at.bofh.it> <sepRg-3ha-25@gated-at.bofh.it>
X-Gm-Message-State	AE9vXwNc8pktxA8HbGa26Z7bNZ0zsyzo2kXVZkF+SBW49bndhWIDnrsD6kGjNiw459I2U1ky/0TH/2jhPBifYw==
X-Received	by 10.107.31.139 with SMTP id f133mr5135032iof.57.1473175013585; Tue, 06 Sep 2016 08:16:53 -0700 (PDT)
MIME-Version	1.0
X-Gmail-Original-Message-ID	<CAGb2v670juZTMovDZCoiW00d3otrBbOWwQXp0NzNeT6sP6zocA@mail.gmail.com>
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>, Thierry Reding <thierry.reding@gmail.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
X-Original-Date	Tue, 6 Sep 2016 23:16:33 +0800
X-Original-Message-ID	<CAGb2v670juZTMovDZCoiW00d3otrBbOWwQXp0NzNeT6sP6zocA@mail.gmail.com>
X-Original-References	<20160906144620.6322-1-maxime.ripard@free-electrons.com> <20160906144620.6322-3-maxime.ripard@free-electrons.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1477497

Show key headers only | View raw

On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The A33 has a significantly different pipeline, with components that differ
> too.
>
> Make sure we had compatible for them.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++++-
>  drivers/gpu/drm/sun4i/sun4i_backend.c                         | 1 +
>  drivers/gpu/drm/sun4i/sun4i_drv.c                             | 8 +++++---
>  drivers/gpu/drm/sun4i/sun4i_tcon.c                            | 8 +++++++-
>  4 files changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> index df8f4aeefe4c..bd3136a5cba5 100644
> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> @@ -26,7 +26,9 @@ TCON
>  The TCON acts as a timing controller for RGB, LVDS and TV interfaces.
>
>  Required properties:
> - - compatible: value should be "allwinner,sun5i-a13-tcon".
> + - compatible: value must be either:
> +   * allwinner,sun5i-a13-tcon
> +   * allwinner,sun8i-a33-tcon
>   - reg: base address and size of memory-mapped region
>   - interrupts: interrupt associated to this IP
>   - clocks: phandles to the clocks feeding the TCON. Three are needed:

You should probably put a note saying the A33 only needs 2 clocks.
You can keep my ack after fixing it.

ChenYu

Thread

[PATCH v2 0/9] drm/sun4i: Introduce A33 display driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
  [PATCH v2 2/9] drm/sun4i: support A33 tcon Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
    Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Chen-Yu Tsai <wens@csie.org> - 2016-09-06 17:10 +0200
    Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Chen-Yu Tsai <wens@csie.org> - 2016-09-06 17:20 +0200
      Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 09:30 +0200
  [PATCH v2 1/9] drm/sun4i: support TCONs without channel 1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
  [PATCH v2 6/9] drm/panel: Add Netron DY E231732 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
    Re: [PATCH v2 6/9] drm/panel: Add Netron DY E231732 Chen-Yu Tsai <wens@csie.org> - 2016-09-06 18:10 +0200
  [PATCH v2 4/9] drm/sun4i: Add a DRC driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
    Re: [PATCH v2 4/9] drm/sun4i: Add a DRC driver Chen-Yu Tsai <wens@csie.org> - 2016-09-06 17:20 +0200
    Re: [linux-sunxi] [PATCH v2 4/9] drm/sun4i: Add a DRC driver Peter Korsgaard <peter@korsgaard.com> - 2016-09-06 22:40 +0200
  Re: [PATCH v2 0/9] drm/sun4i: Introduce A33 display driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 10:20 +0200
  Re: [PATCH v2 0/9] drm/sun4i: Introduce A33 display driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 22:20 +0200

csiph-web