Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478862

Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 06, 2016 at 11:16:33PM +0800, Chen-Yu Tsai wrote:
> On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > The A33 has a significantly different pipeline, with components that differ
> > too.
> >
> > Make sure we had compatible for them.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++++-
> >  drivers/gpu/drm/sun4i/sun4i_backend.c                         | 1 +
> >  drivers/gpu/drm/sun4i/sun4i_drv.c                             | 8 +++++---
> >  drivers/gpu/drm/sun4i/sun4i_tcon.c                            | 8 +++++++-
> >  4 files changed, 19 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > index df8f4aeefe4c..bd3136a5cba5 100644
> > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > @@ -26,7 +26,9 @@ TCON
> >  The TCON acts as a timing controller for RGB, LVDS and TV interfaces.
> >
> >  Required properties:
> > - - compatible: value should be "allwinner,sun5i-a13-tcon".
> > + - compatible: value must be either:
> > +   * allwinner,sun5i-a13-tcon
> > +   * allwinner,sun8i-a33-tcon
> >   - reg: base address and size of memory-mapped region
> >   - interrupts: interrupt associated to this IP
> >   - clocks: phandles to the clocks feeding the TCON. Three are needed:
> 
> You should probably put a note saying the A33 only needs 2 clocks.
> You can keep my ack after fixing it.

I did while applying, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] drm/sun4i: Introduce A33 display driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
  [PATCH v2 2/9] drm/sun4i: support A33 tcon Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
    Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Chen-Yu Tsai <wens@csie.org> - 2016-09-06 17:10 +0200
    Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Chen-Yu Tsai <wens@csie.org> - 2016-09-06 17:20 +0200
      Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 09:30 +0200
  [PATCH v2 1/9] drm/sun4i: support TCONs without channel 1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
  [PATCH v2 6/9] drm/panel: Add Netron DY E231732 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
    Re: [PATCH v2 6/9] drm/panel: Add Netron DY E231732 Chen-Yu Tsai <wens@csie.org> - 2016-09-06 18:10 +0200
  [PATCH v2 4/9] drm/sun4i: Add a DRC driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 16:50 +0200
    Re: [PATCH v2 4/9] drm/sun4i: Add a DRC driver Chen-Yu Tsai <wens@csie.org> - 2016-09-06 17:20 +0200
    Re: [linux-sunxi] [PATCH v2 4/9] drm/sun4i: Add a DRC driver Peter Korsgaard <peter@korsgaard.com> - 2016-09-06 22:40 +0200
  Re: [PATCH v2 0/9] drm/sun4i: Introduce A33 display driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 10:20 +0200
  Re: [PATCH v2 0/9] drm/sun4i: Introduce A33 display driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 22:20 +0200

csiph-web