Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477108

Re: [PATCH] virtio_console: Stop doing DMA on the stack

Show all headers | View raw

On (Tue) 30 Aug 2016 [08:04:15], Andy Lutomirski wrote:
> virtio_console uses a small DMA buffer for control requests.  Move
> that buffer into heap memory.
> 
> Doing virtio DMA on the stack is normally okay on non-DMA-API virtio
> systems (which is currently most of them), but it breaks completely
> if the stack is virtually mapped.
> 
> Tested by typing both directions using picocom aimed at /dev/hvc0.
> 
> Signed-off-by: Andy Lutomirski <luto@kernel.org>

Looks fine,

Reviewed-by: Amit Shah <amit.shah@redhat.com>

> ---
> 
> Hi all-
> 
> This is currently broken in tip:x86/asm.  If you (Amit) like this patch,
> would it make sense for Ingo to add it to -tip?

Yes, I'm fine with that.


     	 Amit

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] virtio_console: Stop doing DMA on the stack Andy Lutomirski <luto@kernel.org> - 2016-08-30 17:10 +0200
  Re: [PATCH] virtio_console: Stop doing DMA on the stack Amit Shah <amit.shah@redhat.com> - 2016-09-06 09:10 +0200
    Re: [PATCH] virtio_console: Stop doing DMA on the stack Ingo Molnar <mingo@kernel.org> - 2016-09-08 08:50 +0200
  [tip:x86/asm] virtio_console: Stop doing DMA on the stack tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-09-08 11:50 +0200

csiph-web